Detect missing page indexes while reading Parquet metadata #6507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etseidl
commented
Oct 3, 2024
| @@ -236,3 +236,63 @@ pub fn parquet_column<'a>( | |||
| .find(|x| parquet_schema.get_column_root_idx(*x) == root_idx)?; | |||
| Some((parquet_idx, field)) | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
There was a problem hiding this comment.
This code is copied from #6463
alamb
approved these changes
Oct 3, 2024
| .err() | ||
| .unwrap(); | ||
| assert_eq!( | ||
| err.to_string(), |
There was a problem hiding this comment.
Well, this certainly is better. Let's see if anyone hits this / is confused
parquet/src/file/metadata/reader.rs
Outdated
| @@ -456,7 +471,7 @@ impl ParquetMetaDataReader { | |||
| } | |||
|
|
|||
| // one-shot parse of footer | |||
There was a problem hiding this comment.
perhaps we can update the docs to mention it updates self.metadata_size 🤔
|
Thanks @etseidl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Addresses part of #6464.
Rationale for this change
If reading metadata from an external cache that lacks the page indexes, but the footer metadata contains page index offsets valid for the original source, attempting to read the page indexes can cause a variety of errors.
What changes are included in this PR?
Modifies
ParqetMetaDataReaderto keep track of the size of the footer metadata, and when reading the page indexes detects if the ranges for the two structures overlap. Returns an EOF error if they do.Are there any user-facing changes?
No, changes are to internal APIs only.