fix: recurse into Map datatype when hydrating dictionaries #6645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hydrating dictionaries for the FlightDataEncoder the Map data type was assumed to not be nested. This change correctly recurses into the Map field to hydrate any dictionaries within the map. Fixes apache#6644
github-actions
bot
added
arrow
tustvold
approved these changes
Oct 30, 2024
crepererum
approved these changes
Oct 30, 2024
adbmal
pushed a commit
to adbmal/arrow-rs
that referenced
this pull request
Nov 2, 2024
When hydrating dictionaries for the FlightDataEncoder the Map data type was assumed to not be nested. This change correctly recurses into the Map field to hydrate any dictionaries within the map. Fixes apache#6644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hydrating dictionaries for the FlightDataEncoder the Map data type was assumed to not be nested. This change correctly recurses into the Map field to hydrate any dictionaries within the map.
Which issue does this PR close?
Closes #6644
Rationale for this change
Fix the bug following the pattern already established for other nested types.
What changes are included in this PR?
Handle the Map type like we do other nested data types.
Are there any user-facing changes?
No