Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template section about API breaking changes #6723

Conversation

findepi
Copy link
Member

@findepi findepi commented Nov 12, 2024

Which issue does this PR close?

None

Rationale for this change

The pull request template section about API breaking changes does not seem possible to follow. The breaking change label doesn't seem to exist. Also, a contributor without triage GitHub permission level cannot set labels.

What changes are included in this PR?

Update the instructions what to do on breaking API changes.

Are there any user-facing changes?

No

The `breaking change` label doesn't seem to exist. Also, a contributor
without triage GitHub permission level cannot set labels. Update the
instructions what to do on breaking API changes.
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tustvold tustvold merged commit 3ee5048 into apache:master Nov 12, 2024
33 checks passed
@findepi findepi deleted the findepi/update-pr-template-section-about-api-breaking-changes-89c4d7 branch November 12, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants