fix: new_null_array for structs #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjchambers
commented
Sep 1, 2021
| .map(|field| ArrayData::new_empty(field.data_type())) | ||
| .collect(), | ||
| )), | ||
| .map(|field| (field.clone(), new_null_array(field.data_type(), length))) |
There was a problem hiding this comment.
One concern I have is that this creates a new null array for the field even if the field was non-nullable. I think that is OK because the enclosing struct is null at all those points, but wasn't 100% sure.
There was a problem hiding this comment.
@nevi-me is the expert here. I believe the nullability is passed from parent to child so your assumption is correct
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
==========================================
+ Coverage 82.47% 82.48% +0.01%
==========================================
Files 168 168
Lines 47690 47701 +11
==========================================
+ Hits 39330 39347 +17
+ Misses 8360 8354 -6
Continue to review full report at Codecov.
|
alamb
pushed a commit
that referenced
this pull request
Sep 9, 2021
alamb
added a commit
that referenced
this pull request
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #734.
Rationale for this change
new_null_arrayshould produce a valid array when used withDataType::StructWhat changes are included in this PR?
Previously failing, now passing test demonstrating that
new_null_arrayreturned a struct array with invalid lengths.Are there any user-facing changes?