[Variant] Support strict casting for Decimals #8483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamzwbao
commented
Sep 27, 2025
| run_test_with_options(values, expected, false); | ||
| } | ||
|
|
||
| #[test] |
There was a problem hiding this comment.
Moved above to group related tests together
scovich
approved these changes
Sep 29, 2025
| |array| -> arrow::array::Decimal32Array { array.as_primitive() }, | ||
| |value| decimal_to_variant_decimal!(value, scale, i32, VariantDecimal4) | ||
| |value| -> Option<_> { | ||
| decimal_to_variant_decimal!(value, scale, i32, VariantDecimal4).map(Variant::from) |
There was a problem hiding this comment.
I don't think we need these Variant::from calls?
The builder append_value should take impl Into<Variant>
and we already define the needed impl From<DecimalXX> for Variant
There was a problem hiding this comment.
Thanks for pointing it out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Support strict casting for Decimal types, also fix the non-strict cast for temporal types where the results should be
Variant:Null(Overflow) insteadNone(missing value)Are these changes tested?
Yes
Are there any user-facing changes?
Yes, decimal casting now supports strict and non-strict modes