-
Couldn't load subscription status.
- Fork 1k
fix: try merging on interleaving list of dict #8652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: try merging on interleaving list of dict #8652
Conversation
5c3ee8c to
d18f6f0
Compare
|
Thanks for this! I am wondering if it makes sense to try to fix this for all cases as well. |
|
I'll try adding the general purpose solution later, may takes 2 days |
Which issue does this PR close?
Rationale for this change
Implement custom interleaving logic for nested data types that have dictionary. Current main branch uses
interleave_fallbackwhich will concat the dictionaries even if they are logically equal (but pointing to different address). There are 2 approaches to work around this:interleave_fallbackreturns error in case dictionary overflow, and then try merging the dictionary and retry.The first solution may provides wider support for any nested data types which contains dictionary (i.e list<struct<list>> )
What changes are included in this PR?
Special interleave handling for specific data types:
Are these changes tested?
Last benchmark