fix: liberal parsing of zero scale decimals #8700
Open
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2025
martin-g
reviewed
Oct 24, 2025
| if scale == 0 && fractionals > 0 { | ||
| // The input string contained some fractional digits after the decimal point despite | ||
| // the scale being zero. Eject all the fractional digits from the number. | ||
| result = result.div_wrapping(base.pow_wrapping(fractionals as _)); |
There was a problem hiding this comment.
Would this be correct if there are many fractional digits, e.g. 20+ ?!
There was a problem hiding this comment.
I think it would, added another test case on that note (("123.000000000000000000004", 123)).
Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
gruuya
force-pushed
the
fix-zero-scale-decimal-parse
branch
from
95a0e5a to
124441b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
parse_decimalwith zero scale #8699.Alternative to #8702 (see #8699 for a discussion).
Rationale for this change
Make parsing of zero-scale decimals more correct/consistent.
What changes are included in this PR?
When a decimal with scale 0 is being parsed, but it has some digits pass the decimal point those will effectively be discarded.
Are these changes tested?
Yes.
Are there any user-facing changes?
Aligned parsing of zero-scale decimals.