fix: zip now treats nulls as false in provided mask regardless of the underlying bit value
#8711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
alamb
approved these changes
Oct 27, 2025
arrow-select/src/zip.rs
Outdated
Comment on lines
328
to
329
| let scalar_truthy = Int32Array::from_iter_values(vec![1, 2, 3, 4, 5, 6]); | ||
| let scalar_falsy = Int32Array::from_iter_values(vec![7, 8, 9, 10, 11, 12]); |
There was a problem hiding this comment.
nit is that these are not scalars (they are arrays)
Suggested change
| let scalar_truthy = Int32Array::from_iter_values(vec![1, 2, 3, 4, 5, 6]); | |
| let scalar_falsy = Int32Array::from_iter_values(vec![7, 8, 9, 10, 11, 12]); | |
| let truthy = Int32Array::from_iter_values(vec![1, 2, 3, 4, 5, 6]); | |
| let falsy = Int32Array::from_iter_values(vec![7, 8, 9, 10, 11, 12]); |
arrow-select/src/zip.rs
Outdated
|
|
||
| #[test] | ||
| fn test_zip_string_array_with_nulls_is_mask_should_be_treated_as_false() { | ||
| let scalar_truthy = StringArray::from_iter_values(vec!["1", "2", "3", "4", "5", "6"]); |
There was a problem hiding this comment.
ditto here, these are not scalar
| } | ||
|
|
||
| fn maybe_prep_null_mask_filter(predicate: &BooleanArray) -> BooleanBuffer { | ||
| // Nulls are treated as false |
There was a problem hiding this comment.
as a follow on PR this would be a nice improvement to make to prep_null_mask_filter itself -- handling arrays without nulls
|
updated |
|
🤖 |
|
Thank you @rluvaton |
|
🤖: Benchmark completed Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
mask
nullsshould be treated asfalse(even if the underlying values are not 0) as described in the docs for zipWhat changes are included in this PR?
used
prep_null_mask_filterbefore iterating over the mask,added tests for both scalar and non scalar (to prepare for #8653)
Are these changes tested?
Yes
Are there any user-facing changes?
Kinda