Add BooleanArray::binary/unary helpers backed by buffer bitwise APIs #8876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add BooleanArray::binary and BooleanArray::unary in arrow-array, implemented in terms of Buffer::bitwise_binary / Buffer::bitwise_unary Update boolean kernels in arrow-arith to use these helpers instead of open-coded bitmap logic Add randomized equivalence tests in arrow-arith to validate the new APIs against existing behavior Add rand as a dev-dependency in arrow-arith for the new tests All behavior should be unchanged; this is an internal refactor toward bitwise API consolidation Tests run locally: cargo test -p arrow-array --lib cargo test -p arrow-arith --lib cargo test -p arrow-select --lib
alamb
reviewed
Nov 19, 2025
| /// * `op` - The unary operation to apply. | ||
| pub fn unary<F>(&self, op: F) -> Self | ||
| where | ||
| F: Fn(u64) -> u64 + Copy, |
Contributor
There was a problem hiding this comment.
can we please change the bound to follow the bitwise unary signature ?
Namely
F: FnMut(u64) -> u64
Contributor
There was a problem hiding this comment.
same thing applies below to binary
Author
There was a problem hiding this comment.
Good catch, thanks! I’ll update BooleanArray::unary to use FnMut(u64) -> u64 to match the bitwise helper signatures.
| /// Returns `Err` if this is shared or its allocation is from an external source or | ||
| /// it is not allocated with alignment [`ALIGNMENT`] | ||
| /// | ||
| /// # Example: Creating a [`MutableBuffer`] from a [`Buffer`] |
Author
There was a problem hiding this comment.
Oversight from PR shuffle I did this morning, splitting these up. It got dropped when I pulled immutable.rs over from my exploratory branch.
I’ll restore the example doc comment in this PR; no behavior change was intended here.
Align BooleanArray helper bounds with Buffer bitwise APIs and restore the removed doc example in immutable.rs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR close?
This PR extracts the BooleanArray bitwise changes from a larger exploratory PR to enable focused and independent review.
Rationale
This change consolidates BooleanArray bitwise logic by leveraging new buffer-level bitwise primitives. By doing so:
Summary of Changes
BooleanArray::binaryandBooleanArray::unarymethods to operate on the value bitmap, built on top ofBuffer::bitwise_binaryandBuffer::bitwise_unary.arrow-arith/src/boolean.rsto use these new helpers instead of manual bitmap logic.arrow-arithto validate the new helpers against existing logic across a range of offsets and lengths.randas a dev-dependency toarrow-arithfor randomized testing.nullifor other higher-level APIs in this PR.Testing
cargo test -p arrow-array --libcargo test -p arrow-arith --libcargo test -p arrow-select --libAll tests pass.
User-Facing Changes
None.
This is an internal refactor: new helpers and tests only. No changes to existing public APIs or observable behavior.