-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [Website] Add datafusion to homepage top banner #150
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format?
See also: |
We might not want it at the actual top-level in the header, I think (there are no other specific implementations listed there). Maybe you can put it in the dropdown list items of "Documentation" ? |
Hi @jorisvandenbossche , thanks for the review. For clarification, datafusion is not a specific implementation of Arrow, but a self-contained query engine built on top of arrow's rust implementation. We actually started with adding Datafusion docs into the current Arrow documentation. But we were given feedback that Datafusion shouldn't be included in the current documentation because it's not an implementation, see: apache/arrow#10982 (comment). Following that feedback, I intentionally moved it out of the documentation dropdown to avoid confusions. |
Yeah, sorry about the imprecise phrasing. I know datafusion is not a specific language implementation of Arrow (and thus it might not fit in the list of languages), but it's still a library implemented on top of Arrow, and so we also currently don't list any specific library in the top-level header. Space in the top-level header is scarce, so we should be cautious with adding content there. I still think it can fit under the Documentation dropdown, but maybe can put another horizontal line between the languages, and then datafusion as a library. |
Agree with Joris, later on we can create a Eventually we're going to have plenty of libraries around the arrow specs so we should probably have a table somewhere highlighting more details about the libraries. |
I see, thanks for the clarification, it makes sense to me. How about we create a query engine or subproject drop down now? I am also expecting to see more subproject popping up within Arrow. That said, I don't have a strong opinion on this, if you all think it's better to put it under the documentation dropdown, I would be more than happy to do so. |
Having a "subprojects" dropdown seems okay to me |
Alright, pushed an update to move datafusion into a new subprojects dropdown :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @houqp!
Following the advice from https://lists.apache.org/thread.html/r5c9341fe5360ae249532724da2bf92bd2ed661d1c58f599212e82107%40%3Cdev.arrow.apache.org%3E.