Skip to content

Commit

Permalink
GH-35192: [Docs] Switch from logo to logo_url to support sphinx >…
Browse files Browse the repository at this point in the history
…= 6 (#35194)

### Rationale for this change

Sphinx dropped support for the `logo` property in release 6.  See sphinx-doc/sphinx#11062  Instead we are supposed to use `logo_url` which has been available since release 4.

### What changes are included in this PR?

Change from `logo` to `logo_url`

### Are these changes tested?

There was a CI test that was failing so yes.

### Are there any user-facing changes?

No.  We already required `sphinx >= 4` and since `logo_url` is available in 4 we should not need to update the minimum sphinx version.
* Closes: #35192

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
  • Loading branch information
westonpace authored Apr 18, 2023
1 parent 1deb740 commit 00072f9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/source/_templates/docs-sidebar.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

<a class="navbar-brand" href="{{ pathto(master_doc) }}">
<img src="{{ pathto('_static/' + logo, 1) }}" class="logo" alt="logo">
<img src="{{ pathto('_static/' + logo_url, 1) }}" class="logo" alt="logo">
</a>

<div id="version-search-wrapper">
Expand Down

0 comments on commit 00072f9

Please sign in to comment.