Apply suggestions from code review - kou

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
apache · Mar 1, 2023 · 1ebe276 · 1ebe276
1 parent d56f4b7
commit 1ebe276
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ci/docker/conda-python-spark.dockerfile b/ci/docker/conda-python-spark.dockerfile
@@ -30,8 +30,8 @@ RUN mamba install -q -y \
         openjdk=${jdk} \
         maven=${maven} \
         pandas && \
-    mamba clean --all
-RUN mamba uninstall -q -y numpy && \
+    mamba clean --all && \
+    mamba uninstall -q -y numpy && \
     /arrow/ci/scripts/install_numpy.sh ${numpy}
 
 # installing specific version of spark

diff --git a/ci/scripts/install_numpy.sh b/ci/scripts/install_numpy.sh
@@ -19,7 +19,7 @@
 
 set -e
 
-if [ "$#" -lt 1 ]; then
+if [ $# -gt 1 ]; then
   echo "Usage: $0 <optional numpy version = latest>"
   exit 1
 fi
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,7 +19,7 @@ @@
     set -e
-    if [ "$#" -lt 1 ]; then
+    if [ $# -gt 1 ]; then
       echo "Usage: $0 <optional numpy version = latest>"
       exit 1
     fi
@@ Expand Down @@