Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
### Rationale for this change Message from compiler: In file included from ../../c_glib/arrow-glib/compute.cpp:28: ../../c_glib/arrow-glib/error.hpp: In instantiation of 'gboolean garrow::check(GError**, const arrow::Status&, CONTEXT_FUNC&&) [with CONTEXT_FUNC = garrow_array_cast(GArrowArray*, GArrowDataType*, GArrowCastOptions*, GError**)::<lambda()>&; gboolean = int; GError = _GError]': ../../c_glib/arrow-glib/error.hpp:71:17: required from 'gboolean garrow::check(GError**, const arrow::Result<T>&, CONTEXT_FUNC&&) [with TYPE = std::shared_ptr<arrow::Array>; CONTEXT_FUNC = garrow_array_cast(GArrowArray*, GArrowDataType*, GArrowCastOptions*, GError**)::<lambda()>; gboolean = int; GError = _GError]' ../../c_glib/arrow-glib/compute.cpp:4707:20: required from here ../../c_glib/arrow-glib/error.hpp:49:19: warning: moving a temporary object prevents copy elision [-Wpessimizing-move] 49 | std::string context = std::move(context_func()); | ^~~~~~~ ../../c_glib/arrow-glib/error.hpp:49:19: note: remove 'std::move' call ../../c_glib/arrow-glib/error.hpp: In instantiation of 'gboolean garrow::check(GError**, const arrow::Status&, CONTEXT_FUNC&&) [with CONTEXT_FUNC = garrow_array_unique(GArrowArray*, GError**)::<lambda()>&; gboolean = int; GError = _GError]': ../../c_glib/arrow-glib/error.hpp:71:17: required from 'gboolean garrow::check(GError**, const arrow::Result<T>&, CONTEXT_FUNC&&) [with TYPE = std::shared_ptr<arrow::Array>; CONTEXT_FUNC = garrow_array_unique(GArrowArray*, GError**)::<lambda()>; gboolean = int; GError = _GError]' ../../c_glib/arrow-glib/compute.cpp:4740:20: required from here ../../c_glib/arrow-glib/error.hpp:49:19: warning: moving a temporary object prevents copy elision [-Wpessimizing-move] ../../c_glib/arrow-glib/error.hpp:49:19: note: remove 'std::move' call ../../c_glib/arrow-glib/error.hpp: In instantiation of 'gboolean garrow::check(GError**, const arrow::Status&, CONTEXT_FUNC&&) [with CONTEXT_FUNC = garrow_array_dictionary_encode(GArrowArray*, GError**)::<lambda()>&; gboolean = int; GError = _GError]': ../../c_glib/arrow-glib/error.hpp:71:17: required from 'gboolean garrow::check(GError**, const arrow::Result<T>&, CONTEXT_FUNC&&) [with TYPE = arrow::Datum; CONTEXT_FUNC = garrow_array_dictionary_encode(GArrowArray*, GError**)::<lambda()>; gboolean = int; GError = _GError]' ../../c_glib/arrow-glib/compute.cpp:4773:20: required from here ../../c_glib/arrow-glib/error.hpp:49:19: warning: moving a temporary object prevents copy elision [-Wpessimizing-move] ../../c_glib/arrow-glib/error.hpp:49:19: note: remove 'std::move' call ### What changes are included in this PR? Remove a needless `std::move()`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #36524 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
- Loading branch information