Skip to content

Commit

Permalink
GH-41176: [C++] Stop defining ARROW_TEST_MEMCHECK in config.h.cmake
Browse files Browse the repository at this point in the history
  • Loading branch information
kou committed Apr 12, 2024
1 parent ec2d7cb commit 6fffa3a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions cpp/src/arrow/filesystem/test_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
#include "arrow/testing/future_util.h"
#include "arrow/testing/gtest_util.h"
#include "arrow/util/async_generator.h"
#include "arrow/util/config.h"
#include "arrow/util/io_util.h"
#include "arrow/util/key_value_metadata.h"
#include "arrow/util/vector.h"
Expand Down Expand Up @@ -753,7 +752,7 @@ void GenericFileSystemTest::TestGetFileInfoSelector(FileSystem* fs) {
}

void GenericFileSystemTest::TestGetFileInfoGenerator(FileSystem* fs) {
#if defined(ADDRESS_SANITIZER) || defined(ARROW_TEST_MEMCHECK)
#if defined(ADDRESS_SANITIZER) || defined(ARROW_VALGRIND)
if (have_false_positive_memory_leak_with_generator()) {
GTEST_SKIP() << "Filesystem have false positive memory leak with generator";
}
Expand Down
1 change: 0 additions & 1 deletion cpp/src/arrow/util/config.h.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
#cmakedefine ARROW_GCS
#cmakedefine ARROW_HDFS
#cmakedefine ARROW_S3
#cmakedefine ARROW_TEST_MEMCHECK
#cmakedefine ARROW_USE_GLOG
#cmakedefine ARROW_USE_NATIVE_INT128
#cmakedefine ARROW_WITH_BROTLI
Expand Down

0 comments on commit 6fffa3a

Please sign in to comment.