Felipe PR comments

apache · Oct 15, 2024 · 8cd7d96 · 8cd7d96
1 parent a838fd0
commit 8cd7d96
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 16 deletions.
diff --git a/cpp/src/arrow/chunk_resolver.h b/cpp/src/arrow/chunk_resolver.h
@@ -290,12 +290,12 @@ class ARROW_EXPORT ChunkResolver {
 };
 
 // Explicitly instantiate template base struct, for DLL linking on Windows
-template struct arrow::TypedChunkLocation<int32_t>;
-template struct arrow::TypedChunkLocation<int16_t>;
-template struct arrow::TypedChunkLocation<int8_t>;
-template struct arrow::TypedChunkLocation<uint8_t>;
-template struct arrow::TypedChunkLocation<uint16_t>;
-template struct arrow::TypedChunkLocation<uint32_t>;
-template struct arrow::TypedChunkLocation<int64_t>;
-template struct arrow::TypedChunkLocation<uint64_t>;
+template struct TypedChunkLocation<int32_t>;
+template struct TypedChunkLocation<int16_t>;
+template struct TypedChunkLocation<int8_t>;
+template struct TypedChunkLocation<uint8_t>;
+template struct TypedChunkLocation<uint16_t>;
+template struct TypedChunkLocation<uint32_t>;
+template struct TypedChunkLocation<int64_t>;
+template struct TypedChunkLocation<uint64_t>;
 } // namespace arrow
diff --git a/cpp/src/arrow/chunk_resolver_benchmark.cc b/cpp/src/arrow/chunk_resolver_benchmark.cc
@@ -28,9 +28,6 @@
 
 namespace arrow {
 
-using arrow::ChunkResolver;
-using arrow::TypedChunkLocation;
-
 namespace {
 
 int64_t constexpr kChunkedArrayLength = std::numeric_limits<uint16_t>::max();

diff --git a/cpp/src/arrow/chunked_array_test.cc b/cpp/src/arrow/chunked_array_test.cc
@@ -36,10 +36,6 @@
 
 namespace arrow {
 
-using arrow::ChunkLocation;
-using arrow::ChunkResolver;
-using arrow::TypedChunkLocation;
-
 class TestChunkedArray : public ::testing::Test {
  protected:
  virtual void Construct() {

diff --git a/cpp/src/arrow/compute/kernels/vector_sort.cc b/cpp/src/arrow/compute/kernels/vector_sort.cc
@@ -23,7 +23,6 @@
 
 namespace arrow {
 
-using arrow::ChunkLocation;
 using internal::checked_cast;
 
 namespace compute {