Skip to content

Commit

Permalink
Fix TestFlightSqlServer#TestCommandGetSqlInfoNoInfo failure on CI
Browse files Browse the repository at this point in the history
  • Loading branch information
rafael-telles committed Dec 20, 2021
1 parent a626538 commit 94f98fe
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
4 changes: 3 additions & 1 deletion cpp/src/arrow/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,9 @@ if(ARROW_FLIGHT_SQL)
add_subdirectory(flight/sql)
endif()

if(ARROW_FLIGHT AND ARROW_FLIGHT_SQL AND ARROW_BUILD_INTEGRATION)
if(ARROW_FLIGHT
AND ARROW_FLIGHT_SQL
AND ARROW_BUILD_INTEGRATION)
add_subdirectory(flight/integration_tests)
endif()

Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/flight/sql/server_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ TEST_F(TestFlightSqlServer, TestCommandGetSqlInfoNoInfo) {
ASSERT_OK_AND_ASSIGN(auto flight_info, sql_client->GetSqlInfo(call_options, {999999}));

EXPECT_RAISES_WITH_MESSAGE_THAT(
KeyError, ::testing::HasSubstr("No information for SQL info number 999999."),
KeyError, ::testing::HasSubstr("No information for SQL info number 999999"),
sql_client->DoGet(call_options, flight_info->endpoints()[0].ticket));
}

Expand Down
2 changes: 1 addition & 1 deletion dev/archery/archery/integration/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ def run_all_tests(with_cpp=True, with_java=True, with_js=True,
),
Scenario(
"flight_sql",
description="Ensure that Flight SQL protocol is working as expected.",
description="Ensure Flight SQL protocol is working as expected.",
skip={"Rust", "Go"}
),
]
Expand Down
5 changes: 3 additions & 2 deletions dev/archery/archery/integration/tester_java.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,9 @@ class JavaTester(Tester):
ARROW_FLIGHT_JAR = os.environ.get(
'ARROW_FLIGHT_JAVA_INTEGRATION_JAR',
os.path.join(ARROW_ROOT_DEFAULT,
'java/flight/flight-integration-tests/target/flight-integration-tests-{}-'
'jar-with-dependencies.jar'.format(_arrow_version)))
'java/flight/flight-integration-tests/target/'
'flight-integration-tests-{}-jar-with-dependencies.jar'
.format(_arrow_version)))
ARROW_FLIGHT_SERVER = ('org.apache.arrow.flight.integration.tests.'
'IntegrationTestServer')
ARROW_FLIGHT_CLIENT = ('org.apache.arrow.flight.integration.tests.'
Expand Down

0 comments on commit 94f98fe

Please sign in to comment.