Skip to content

Commit

Permalink
GH-41201: [C++] Fix mistake in integration test
Browse files Browse the repository at this point in the history
  • Loading branch information
lidavidm committed Apr 16, 2024
1 parent e0f31aa commit ca6161e
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions cpp/src/arrow/flight/integration_tests/test_integration.cc
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,8 @@ class ExpirationTimeRenewFlightEndpointScenario : public Scenario {
/// both "lol_invalid", which will result in errors attempting to set either.
class SessionOptionsServer : public sql::FlightSqlServerBase {
static inline const std::string invalid_option_name = "lol_invalid";
static inline const SessionOptionValue invalid_option_value = "lol_invalid";
static inline const SessionOptionValue invalid_option_value =
std::string("lol_invalid");

const std::string session_middleware_key;
// These will never be threaded so using a plain map and no lock
Expand Down Expand Up @@ -852,7 +853,7 @@ class SessionOptionsScenario : public Scenario {
{{"foolong", 123L},
{"bardouble", 456.0},
{"lol_invalid", "this won't get set"},
{"key_with_invalid_value", "lol_invalid"},
{"key_with_invalid_value", std::string("lol_invalid")},
{"big_ol_string_list", std::vector<std::string>{"a", "b", "sea", "dee", " ",
" ", "geee", "(づ。◕‿‿◕。)づ"}}}};
ARROW_ASSIGN_OR_RAISE(auto res1, client.SetSessionOptions({}, req1));
Expand All @@ -878,16 +879,16 @@ class SessionOptionsScenario : public Scenario {
}
// Update
ARROW_ASSIGN_OR_RAISE(
auto res3,
client.SetSessionOptions(
{}, SetSessionOptionsRequest{
{{"foolong", std::monostate{}},
{"big_ol_string_list", "a,b,sea,dee, , ,geee,(づ。◕‿‿◕。)づ"}}}));
auto res3, client.SetSessionOptions(
{}, SetSessionOptionsRequest{
{{"foolong", std::monostate{}},
{"big_ol_string_list",
std::string("a,b,sea,dee, , ,geee,(づ。◕‿‿◕。)づ")}}}));
ARROW_ASSIGN_OR_RAISE(auto res4, client.GetSessionOptions({}, {}));
if (res4.session_options !=
std::map<std::string, SessionOptionValue>{
{"bardouble", 456.0},
{"big_ol_string_list", "a,b,sea,dee, , ,geee,(づ。◕‿‿◕。)づ"}}) {
{"big_ol_string_list", std::string("a,b,sea,dee, , ,geee,(づ。◕‿‿◕。)づ")}}) {
return Status::Invalid("res4 incorrect: " + res4.ToString());
}

Expand Down

0 comments on commit ca6161e

Please sign in to comment.