inline writeLong method in decimal256

apache · Oct 21, 2020 · cfa3513 · cfa3513
1 parent f582b8a
commit cfa3513
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 15 deletions.
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/Decimal256Vector.java b/java/vector/src/main/java/org/apache/arrow/vector/Decimal256Vector.java
@@ -329,7 +329,12 @@ public void set(int index, BigDecimal value) {
    */
   public void set(int index, long value) {
     BitVectorHelper.setBit(validityBuffer, index);
-    DecimalUtility.writeLongToArrowBufBigDecimal(value, valueBuffer, index);
+    final long addressOfValue = valueBuffer.memoryAddress() + (long) index * TYPE_WIDTH;
+    PlatformDependent.putLong(addressOfValue, value);
+    final long padValue = Long.signum(value) == -1 ? -1L : 0L;
+    PlatformDependent.putLong(addressOfValue + Long.BYTES, padValue);
+    PlatformDependent.putLong(addressOfValue + 2 * Long.BYTES, padValue);
+    PlatformDependent.putLong(addressOfValue + 3 * Long.BYTES, padValue);
   }
 
   /**

diff --git a/java/vector/src/main/java/org/apache/arrow/vector/util/DecimalUtility.java b/java/vector/src/main/java/org/apache/arrow/vector/util/DecimalUtility.java
@@ -130,25 +130,12 @@ public static void writeBigDecimalToArrowBuf(BigDecimal value, ArrowBuf bytebuf,
    * Write the given long to the ArrowBuf at the given value index.
    */
   public static void writeLongToArrowBuf(long value, ArrowBuf bytebuf, int index) {
-    final long addressOfValue = bytebuf.memoryAddress() + (long) index * 16;
+    final long addressOfValue = bytebuf.memoryAddress() + (long) index * DECIMAL_BYTE_LENGTH;
     PlatformDependent.putLong(addressOfValue, value);
     final long padValue = Long.signum(value) == -1 ? -1L : 0L;
     PlatformDependent.putLong(addressOfValue + Long.BYTES, padValue);
   }
 
-  /**
-   * Write value to the buffer extending it to 32 bytes at the given index. 
-   */
-  public static void writeLongToArrowBufBigDecimal(long value, ArrowBuf bytebuf, int index) {
-    final long addressOfValue = bytebuf.memoryAddress() + (long) index * 32;
-    PlatformDependent.putLong(addressOfValue, value);
-    final long padValue = Long.signum(value) == -1 ? -1L : 0L;
-    PlatformDependent.putLong(addressOfValue + Long.BYTES, padValue);
-    PlatformDependent.putLong(addressOfValue + 2 * Long.BYTES, padValue);
-    PlatformDependent.putLong(addressOfValue + 3 * Long.BYTES, padValue);
-  }
-
-
   /**
    * Write the given byte array to the ArrowBuf at the given value index. Will throw an
    * UnsupportedOperationException if the decimal size is greater than the Decimal vector byte