Skip to content

Commit

Permalink
Make the function pointer fields in the C API structs internal.
Browse files Browse the repository at this point in the history
  • Loading branch information
teo-tsirpanis authored Jun 10, 2023
1 parent 154b86c commit e9365fc
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion csharp/src/Apache.Arrow/C/CArrowArray.cs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public unsafe struct CArrowArray
public byte** buffers;
public CArrowArray** children;
public CArrowArray* dictionary;
public delegate* unmanaged[Stdcall]<CArrowArray*, void> release;
internal delegate* unmanaged[Stdcall]<CArrowArray*, void> release;
public void* private_data;

/// <summary>
Expand Down
8 changes: 4 additions & 4 deletions csharp/src/Apache.Arrow/C/CArrowArrayStream.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,15 @@ public unsafe struct CArrowArrayStream
///
/// Return value: 0 if successful, an `errno`-compatible error code otherwise.
///</summary>
public delegate* unmanaged[Stdcall]<CArrowArrayStream*, CArrowSchema*, int> get_schema;
internal delegate* unmanaged[Stdcall]<CArrowArrayStream*, CArrowSchema*, int> get_schema;

/// <summary>
/// Callback to get the next array. If no error and the array is released, the stream has ended.
/// If successful, the ArrowArray must be released independently from the stream.
///
/// Return value: 0 if successful, an `errno`-compatible error code otherwise.
/// </summary>
public delegate* unmanaged[Stdcall]<CArrowArrayStream*, CArrowArray*, int> get_next;
internal delegate* unmanaged[Stdcall]<CArrowArrayStream*, CArrowArray*, int> get_next;

/// <summary>
/// Callback to get optional detailed error information. This must only
Expand All @@ -54,13 +54,13 @@ public unsafe struct CArrowArrayStream
/// Return value: pointer to a null-terminated character array describing the last
/// error, or NULL if no description is available.
///</summary>
public delegate* unmanaged[Stdcall]<CArrowArrayStream*, byte*> get_last_error;
internal delegate* unmanaged[Stdcall]<CArrowArrayStream*, byte*> get_last_error;

/// <summary>
/// Release callback: release the stream's own resources. Note that arrays returned by
/// get_next must be individually released.
/// </summary>
public delegate* unmanaged[Stdcall]<CArrowArrayStream*, void> release;
internal delegate* unmanaged[Stdcall]<CArrowArrayStream*, void> release;

public void* private_data;

Expand Down
2 changes: 1 addition & 1 deletion csharp/src/Apache.Arrow/C/CArrowSchema.cs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public unsafe struct CArrowSchema
public long n_children;
public CArrowSchema** children;
public CArrowSchema* dictionary;
public delegate* unmanaged[Stdcall]<CArrowSchema*, void> release;
internal delegate* unmanaged[Stdcall]<CArrowSchema*, void> release;
public void* private_data;

/// <summary>
Expand Down

0 comments on commit e9365fc

Please sign in to comment.