[C++] Uniform usage of Google cpu_features library accross the codebase

[asfimport]

Is there any objection to use the Google's standard cpu_features library https://github.com/google/cpu_features instead of https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/cpu-info.h. So far it has been used in 3 place only which can be easily changed.

Reporter: Areg Melik-Adamyan / @aregm
Assignee: Areg Melik-Adamyan / @aregm

PRs and other links:

• GitHub Pull Request #4201

_{Note: This issue was originally created as ARROW-5196. Please see the migration documentation for further details.}

[asfimport]

Antoine Pitrou / @pitrou:
This sounds reasonable to me.

[asfimport]

Wes McKinney / @wesm:
It seems small enough that we may add it to arrow/vendored rather than introducing another thirdparty library to manage

[asfimport]

Areg Melik-Adamyan / @aregm:
I started to clean up the CpuInfo, which seems overdesigned - do you want to preserve the existing API, which is not used anywhere, or we can move to cpu_features API wrappers?

[asfimport]

Wes McKinney / @wesm:
It's not necessary to preserve the API. IIRC it originated from Apache Impala

https://github.com/apache/impala/blob/master/be/src/util/cpu-info.h

[asfimport]

Areg Melik-Adamyan / @aregm:
Ok, I'll add to third_party, and re-engineer the PR. BTW, @pitrou AppVeyor fails to build due to some problem with doubel_conversion library, I don't see it locally neither on Windows nor on Linux, is this a glitch on AppVeyor?

[asfimport]

Antoine Pitrou / @pitrou:
No, AppVeyor builds normally succeed.

[asfimport]

Antoine Pitrou / @pitrou:
It seems this effort has stalled. Our current CPU inspection capabilities are bit crude, but we don't have any pressing needs.