-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] Allow appending null on sparse union and map builders #31621
Comments
domoritz
pushed a commit
that referenced
this issue
Sep 7, 2023
This PR fixes `Union` null handling, and re-enables the disabled `SparseUnion` test. The format doc [says](https://arrow.apache.org/docs/format/Columnar.html#union-layout): > Unlike other data types, unions do not have their own validity bitmap. Therefore we need to remove null masks from union types and allow them to delegate validity to their children. Also fixes #37063 for good measure. * Closes: #31621 * Closes: #37063 * Closes #24123 * Closes #17168 Authored-by: ptaylor <paul.e.taylor@me.com> Signed-off-by: Dominik Moritz <domoritz@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
This PR fixes `Union` null handling, and re-enables the disabled `SparseUnion` test. The format doc [says](https://arrow.apache.org/docs/format/Columnar.html#union-layout): > Unlike other data types, unions do not have their own validity bitmap. Therefore we need to remove null masks from union types and allow them to delegate validity to their children. Also fixes apache#37063 for good measure. * Closes: apache#31621 * Closes: apache#37063 * Closes apache#24123 * Closes apache#17168 Authored-by: ptaylor <paul.e.taylor@me.com> Signed-off-by: Dominik Moritz <domoritz@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
This PR fixes `Union` null handling, and re-enables the disabled `SparseUnion` test. The format doc [says](https://arrow.apache.org/docs/format/Columnar.html#union-layout): > Unlike other data types, unions do not have their own validity bitmap. Therefore we need to remove null masks from union types and allow them to delegate validity to their children. Also fixes apache#37063 for good measure. * Closes: apache#31621 * Closes: apache#37063 * Closes apache#24123 * Closes apache#17168 Authored-by: ptaylor <paul.e.taylor@me.com> Signed-off-by: Dominik Moritz <domoritz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See #12451 and in particular #12451 (review).
Reporter: Dominik Moritz / @domoritz
Note: This issue was originally created as ARROW-16222. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: