[C++][Gandiva] AppVeyor Windows builds failing due to 'diaguids.lib'

[asfimport]

Observed in AppVeyor across a few PRs

(arrow) C:\projects\arrow\cpp\build>cmake --build . --target install --config Release   || exit /B 
ninja: error: 'C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by 'release/gandiva.dll', missing and no known rule to make it

Reporter: David Li / @lidavidm
Assignee: Jin Shang / @js8544

Related issues:

• [C++][Gandiva] Solve LLVM 15 CI performace and compatibility issues (is related to)

PRs and other links:

• GitHub Pull Request #14228

_{Note: This issue was originally created as ARROW-17830. Please see the migration documentation for further details.}

[asfimport]

David Li / @lidavidm:
CC @js8544 perhaps

[asfimport]

Jin Shang / @js8544:
Somehow it's looking for the Enterprise version of Visual Studio. Let me see if I can point it to the Community version.

[asfimport]

Jin Shang / @js8544:
After some digging I found out there's a bug with Conda's packaging of LLVM on windows. 

LLVM's target LLVMDebugInfoPDB has a dependency on this file "${LIBPDB_LINK_FOLDERS}diaguids.lib" (https://github.com/llvm/llvm-project/blob/main/llvm/lib/DebugInfo/PDB/CMakeLists.txt#L17). 

I downloaded Conda's llvmdev package for windows win-64/llvmdev-15.0.1-h0f93eaf_0.tar.bz2 from: https://anaconda.org/conda-forge/llvmdev/files

In the file Library/lib/cmake/LLVMExports.cmake line 410, it writes:

set_target_properties(LLVMDebugInfoPDB PROPERTIES  INTERFACE_LINK_LIBRARIES "C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/DIA SDK/lib/amd64/diaguids.lib;LLVMBinaryFormat;LLVMObject;LLVMSupport;LLVMDebugInfoCodeView;LLVMDebugInfoMSF") 

The full path is specified instead of using CMake vars. Apparently Conda packaged it on a platform with VS2019 Enterprise installed.

I am not familiar with Conda at all. Any idea where I should report this bug to? CC @lidavidm @pitrou @kou 

For now I will disable Gandiva build on AppVeyor.

For now I will pin LLVM's version to 14 on AppVeyor as per kou's suggestion.

[asfimport]

David Li / @lidavidm:
It should be here: https://github.com/conda-forge/llvmdev-feedstock/issues

Thanks for digging into this!

[asfimport]

Jin Shang / @js8544:
Issue submitted: conda-forge/llvmdev-feedstock#175

[asfimport]

Kouhei Sutou / @kou:
Issue resolved by pull request 14228
#14228