[R] Provide extra output for failed builds #34105
Comments
|
with cmake it is very possible that the error is not in the last lines due to multithreading so it might be better to grep for the actual "CMake Error:" or something? Or are we saving the log somewhere? In that case it might also be good to direct the user to the full log file. (in addition to output what ever part of the log we choose) |
raulcd
pushed a commit
that referenced
this issue
Sep 15, 2023
### Rationale for this change This is a replacement for the previous PR #37698. The rationale for this PR is providing extra output for R package builds where the C++ build fails ### What changes are included in this PR? Update the system call to save output when building Arrow C++ from the R package and output it if it's failed ### Are these changes tested? No automated tests but the changes have been tested manually. ### Are there any user-facing changes? Yes, but only for users building the R package from source which is hopefully not common. * Closes: #34105 Lead-authored-by: Bryce Mecum <petridish@gmail.com> Co-authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
thisisnic
added a commit
to thisisnic/arrow
that referenced
this issue
Sep 15, 2023
) ### Rationale for this change This is a replacement for the previous PR apache#37698. The rationale for this PR is providing extra output for R package builds where the C++ build fails ### What changes are included in this PR? Update the system call to save output when building Arrow C++ from the R package and output it if it's failed ### Are these changes tested? No automated tests but the changes have been tested manually. ### Are there any user-facing changes? Yes, but only for users building the R package from source which is hopefully not common. * Closes: apache#34105 Lead-authored-by: Bryce Mecum <petridish@gmail.com> Co-authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
) ### Rationale for this change This is a replacement for the previous PR apache#37698. The rationale for this PR is providing extra output for R package builds where the C++ build fails ### What changes are included in this PR? Update the system call to save output when building Arrow C++ from the R package and output it if it's failed ### Are these changes tested? No automated tests but the changes have been tested manually. ### Are there any user-facing changes? Yes, but only for users building the R package from source which is hopefully not common. * Closes: apache#34105 Lead-authored-by: Bryce Mecum <petridish@gmail.com> Co-authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
) ### Rationale for this change This is a replacement for the previous PR apache#37698. The rationale for this PR is providing extra output for R package builds where the C++ build fails ### What changes are included in this PR? Update the system call to save output when building Arrow C++ from the R package and output it if it's failed ### Are these changes tested? No automated tests but the changes have been tested manually. ### Are there any user-facing changes? Yes, but only for users building the R package from source which is hopefully not common. * Closes: apache#34105 Lead-authored-by: Bryce Mecum <petridish@gmail.com> Co-authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
When building the R package and the Arrow C++ library build fails, there's very little output unless the user has set
ARROW_R_DEVtoTRUE. We could instead output the last N lines of the output in the case of build failures, to provide more context.Component(s)
R
The text was updated successfully, but these errors were encountered: