Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Fix IntervalMonthDayNanoVector constructor to set correct minor type #35733

Closed
wgtmac opened this issue May 24, 2023 · 0 comments · Fixed by #35734
Closed

[Java] Fix IntervalMonthDayNanoVector constructor to set correct minor type #35733

wgtmac opened this issue May 24, 2023 · 0 comments · Fixed by #35734
Assignees
@wgtmac
Labels
Component: Java Type: bug
Milestone
13.0.0

Comments

@wgtmac
Copy link
Member

wgtmac commented May 24, 2023

Describe the bug, including details regarding any error messages, version, and platform.

Currently the IntervalMonthDayNanoVector constructor does not set minor type correctly as below:

  public IntervalMonthDayNanoVector(String name, BufferAllocator allocator) {
    this(name, FieldType.nullable(MinorType.INTERVALDAY.getType()), allocator);
  }

Component(s)

Java
wgtmac added a commit to wgtmac/arrow that referenced this issue May 24, 2023
@wgtmac
apacheGH-35733: [Java] Fix minor type in IntervalMonthDayNanoVector ctor
b3c357c
wgtmac added a commit to wgtmac/arrow that referenced this issue May 24, 2023
@wgtmac
apacheGH-35733: [Java] Fix minor type in IntervalMonthDayNanoVector ctor
fc5e849
@github-actions github-actions bot mentioned this issue May 24, 2023
Merged
lidavidm pushed a commit that referenced this issue May 24, 2023
@wgtmac
GH-35733: [Java] Fix minor type in IntervalMonthDayNanoVector ctor (#…
5582605 
…35734)

### Rationale for this change

The constructor of IntervalMonthDayNanoVector does not set minor type correctly.

```java
  public IntervalMonthDayNanoVector(String name, BufferAllocator allocator) {
    this(name, FieldType.nullable(MinorType.INTERVALDAY.getType()), allocator);
  }
```

It should be `MinorType.INTERVALMONTHDAYNANO`.

### What changes are included in this PR?

Change it to set `MinorType.INTERVALMONTHDAYNANO`.

### Are these changes tested?

Added test to verify vector type.

### Are there any user-facing changes?

No.
* Closes: #35733

Authored-by: Gang Wu <ustcwg@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 13.0.0 milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wgtmac wgtmac

Labels
Component: Java Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35733: [Java] Fix minor type in IntervalMonthDayNanoVector ctor wgtmac/arrow
2 participants
@lidavidm @wgtmac