Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Simplify concurrency in as-of-join node #36092

Closed
rtpsw opened this issue Jun 15, 2023 · 1 comment · Fixed by #36094
Closed

[C++] Simplify concurrency in as-of-join node #36092

rtpsw opened this issue Jun 15, 2023 · 1 comment · Fixed by #36094
Assignees
@rtpsw
Labels
Component: C++ Type: enhancement
Milestone
13.0.0

Comments

@rtpsw
Copy link
Contributor

rtpsw commented Jun 15, 2023

Describe the enhancement requested

Currently, as-of-join node has internal invocations that require thread-safe synchronization but can be simplified to not require this:

  • Invalidation of the key hasher.
  • Updating of the memo-store's time upon receiving a batch.

Both of these can be moved to the processing thread, instead of invoked from the input-receiving thread.

Component(s)

C++
@rtpsw
Copy link
Contributor Author

rtpsw commented Jun 15, 2023

take

rtpsw added a commit to rtpsw/arrow that referenced this issue Jun 15, 2023
@rtpsw
apacheGH-36092: [C++] Simplify concurrency in as-of-join node
582f572
@github-actions github-actions bot mentioned this issue Jun 15, 2023
Merged
icexelloss pushed a commit that referenced this issue Jun 22, 2023
@rtpsw
GH-36092: [C++] Simplify concurrency in as-of-join node (#36094)
1b29d95 
### What changes are included in this PR?

The key hasher invalidation and memo-store time updating are moved to the processing thread.

### Are these changes tested?

Yes, by existing tests.

### Are there any user-facing changes?

No.
* Closes: #36092

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Li Jin <ice.xelloss@gmail.com>
@icexelloss icexelloss added this to the 13.0.0 milestone Jun 22, 2023
@rtpsw rtpsw mentioned this issue Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtpsw rtpsw

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36092: [C++] Simplify concurrency in as-of-join node rtpsw/arrow
2 participants
@icexelloss @rtpsw