-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dev] Merge PR script defaults to the wrong milestone when merging #36634
Comments
…questing info from GitHub
@kou there are some branches which I am unsure should be on the repo, like old RC branches or some feature branches like: I think all those can be removed, for the old RC ones we have the release and the maintenance branch. Are you ok with me removing those? edit: typo |
Thanks @kou , I've removed: |
…ng info from GitHub (#36637) ### Rationale for this change We currently were missing maintenance branches due to pagination on GH API. ### What changes are included in this PR? Check whether the API is returning a paginated view and extend the list returned. ### Are these changes tested? I have tested locally: ``` (Pdb) pr.maintenance_branches ['maint-0.11.x', 'maint-0.12.x', 'maint-0.14.x', 'maint-0.15.x', 'maint-0.17.x', 'maint-1.0.x', 'maint-3.0.x', 'maint-4.0.x', 'maint-6.0.x', 'maint-7.0.x', 'maint-7.0.1', 'maint-8.0.x', 'maint-9.0.0', 'maint-10.0.x', 'maint-10.0.0', 'maint-10.0.1', 'maint-11.0.0', 'maint-12.0.x', 'maint-12.0.0', 'maint-12.0.1', 'maint-13.0.0'] (Pdb) c Enter fix version [14.0.0]: ``` ### Are there any user-facing changes? No * Closes: #36634 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…questing info from GitHub (apache#36637) ### Rationale for this change We currently were missing maintenance branches due to pagination on GH API. ### What changes are included in this PR? Check whether the API is returning a paginated view and extend the list returned. ### Are these changes tested? I have tested locally: ``` (Pdb) pr.maintenance_branches ['maint-0.11.x', 'maint-0.12.x', 'maint-0.14.x', 'maint-0.15.x', 'maint-0.17.x', 'maint-1.0.x', 'maint-3.0.x', 'maint-4.0.x', 'maint-6.0.x', 'maint-7.0.x', 'maint-7.0.1', 'maint-8.0.x', 'maint-9.0.0', 'maint-10.0.x', 'maint-10.0.0', 'maint-10.0.1', 'maint-11.0.0', 'maint-12.0.x', 'maint-12.0.0', 'maint-12.0.1', 'maint-13.0.0'] (Pdb) c Enter fix version [14.0.0]: ``` ### Are there any user-facing changes? No * Closes: apache#36634 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…questing info from GitHub (apache#36637) ### Rationale for this change We currently were missing maintenance branches due to pagination on GH API. ### What changes are included in this PR? Check whether the API is returning a paginated view and extend the list returned. ### Are these changes tested? I have tested locally: ``` (Pdb) pr.maintenance_branches ['maint-0.11.x', 'maint-0.12.x', 'maint-0.14.x', 'maint-0.15.x', 'maint-0.17.x', 'maint-1.0.x', 'maint-3.0.x', 'maint-4.0.x', 'maint-6.0.x', 'maint-7.0.x', 'maint-7.0.1', 'maint-8.0.x', 'maint-9.0.0', 'maint-10.0.x', 'maint-10.0.0', 'maint-10.0.1', 'maint-11.0.0', 'maint-12.0.x', 'maint-12.0.0', 'maint-12.0.1', 'maint-13.0.0'] (Pdb) c Enter fix version [14.0.0]: ``` ### Are there any user-facing changes? No * Closes: apache#36634 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Describe the bug, including details regarding any error messages, version, and platform.
I saw that lots of PRs were merged with the wrong milestone (13.0.0) now that the maintenance branch has been created it should default to 14.0.0 but it is not as seen:
It does seem that the
12.0.0
and12.0.1
maintenance branches are also not shown:It might be due to pagination when requesting branches:
Component(s)
Developer Tools
The text was updated successfully, but these errors were encountered: