Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Docs] Enable Gandiva build as part of Java maven commands #36927

Closed
davisusanibar opened this issue Jul 28, 2023 · 0 comments · Fixed by #36929
Closed

[Java][Docs] Enable Gandiva build as part of Java maven commands #36927

davisusanibar opened this issue Jul 28, 2023 · 0 comments · Fixed by #36929

Comments

@davisusanibar
Copy link
Contributor

Describe the enhancement requested

Enable Gandiva build as part of Java maven profile commands.

Current Java mvn command to build Gandiva library finished with errors:

$ mvn generate-resources \
    -Pgenerate-libs-jni-macos-linux \
    -DARROW_GANDIVA=ON \
    -DARROW_JAVA_JNI_ENABLE_GANDIVA=ON \
    -N


....
[ 40%] Built target arrow_java_jni_gandiva_jar
[ 45%] Running Protobuf compiler on Types.proto
[ 45%] Built target garrow_java_jni_gandiva_proto
[ 50%] Building CXX object gandiva/CMakeFiles/arrow_java_jni_gandiva.dir/src/main/cpp/config_builder.cc.o
[ 54%] Building CXX object gandiva/CMakeFiles/arrow_java_jni_gandiva.dir/src/main/cpp/config_holder.cc.o
[ 59%] Building CXX object gandiva/CMakeFiles/arrow_java_jni_gandiva.dir/src/main/cpp/expression_registry_helper.cc.o
/Users/dsusanibar/voltron/jiraarrow/ultimo/arrow/java/gandiva/src/main/cpp/expression_registry_helper.cc:155:51: error: no member named 'ByteSizeLong' in 'types::GandivaDataTypes'; did you mean 'ByteSize'?
  auto size = static_cast<int>(gandiva_data_types.ByteSizeLong());
                                                  ^~~~~~~~~~~~
                                                  ByteSize
/Users/dsusanibar/voltron/jiraarrow/ultimo/arrow/java-jni/gandiva/Types.pb.h:2373:7: note: 'ByteSize' declared here
  int ByteSize() const;
      ^
/Users/dsusanibar/voltron/jiraarrow/ultimo/arrow/java/gandiva/src/main/cpp/expression_registry_helper.cc:184:50: error: no member named 'ByteSizeLong' in 'types::GandivaFunctions'; did you mean 'ByteSize'?
  auto size = static_cast<int>(gandiva_functions.ByteSizeLong());
                                                 ^~~~~~~~~~~~
                                                 ByteSize
/Users/dsusanibar/voltron/jiraarrow/ultimo/arrow/java-jni/gandiva/Types.pb.h:2458:7: note: 'ByteSize' declared here
  int ByteSize() const;
      ^
2 errors generated.
make[2]: *** [gandiva/CMakeFiles/arrow_java_jni_gandiva.dir/src/main/cpp/expression_registry_helper.cc.o] Error 1
make[1]: *** [gandiva/CMakeFiles/arrow_java_jni_gandiva.dir/all] Error 2
make: *** [all] Error 2
[ERROR] Command execution failed.

Component(s)

Documentation, Java

@kou kou closed this as completed in #36929 Aug 1, 2023
kou added a commit that referenced this issue Aug 1, 2023
…mands (#36929)

### Rationale for this change

To close: #36927

### What changes are included in this PR?

- Enable MacOS Gandiva build as part of Java maven commands
- Enable Windows ORC build as part of Java maven commands

### Are these changes tested?

Yes:
- Gandiva: mvn generate-resources -Pgenerate-libs-jni-macos-linux -N
- ORC: mvn generate-resources -Pgenerate-libs-jni-windows -N

### Are there any user-facing changes?

No
* Closes: #36927

Lead-authored-by: david dali susanibar arce <davi.sarces@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Aug 1, 2023
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
…en commands (apache#36929)

### Rationale for this change

To close: apache#36927

### What changes are included in this PR?

- Enable MacOS Gandiva build as part of Java maven commands
- Enable Windows ORC build as part of Java maven commands

### Are these changes tested?

Yes:
- Gandiva: mvn generate-resources -Pgenerate-libs-jni-macos-linux -N
- ORC: mvn generate-resources -Pgenerate-libs-jni-windows -N

### Are there any user-facing changes?

No
* Closes: apache#36927

Lead-authored-by: david dali susanibar arce <davi.sarces@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
…en commands (apache#36929)

### Rationale for this change

To close: apache#36927

### What changes are included in this PR?

- Enable MacOS Gandiva build as part of Java maven commands
- Enable Windows ORC build as part of Java maven commands

### Are these changes tested?

Yes:
- Gandiva: mvn generate-resources -Pgenerate-libs-jni-macos-linux -N
- ORC: mvn generate-resources -Pgenerate-libs-jni-windows -N

### Are there any user-facing changes?

No
* Closes: apache#36927

Lead-authored-by: david dali susanibar arce <davi.sarces@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment