-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MATLAB] Add test cases which verify that the NumFields
, BitWidth
, and ID
properties can not be modified to hFixedWidth
test class
#37253
Comments
kevingurney
added a commit
that referenced
this issue
Aug 22, 2023
…`BitWidth`, and `ID` properties can not be modified to `hFixedWidth` test class (#37316) ### Rationale for this change As @ sgilmore10 pointed out in #37250 (comment), it makes sense to move the tests which verify that the `NumFields`, `BitWidth`, and `ID` properties cannot be set into the `hFixedWidthType` superclass, rather than having these tests implemented in `tTime32Type` and `tTime64Type`, since they are common to all fixed width types. ### What changes are included in this PR? 1. Moved tests which verify that the `BitWidth`, `NumFields`, and `ID` properties cannot be set out of the `tTime32Type` and `tTime64Type` classes and into the superclass `hFixedWidthType`. 2. Fixed typo in `tTime32Type` and `tTime64Type`. Changed variable name `schema` to `type`. ### Are these changes tested? Yes. 1. Moved tests which verify that the `BitWidth`, `NumFields`, and `ID` properties cannot be set out of the `tTime32Type` and `tTime64Type` classes and into the superclass `hFixedWidthType`. ### Are there any user-facing changes? No. This pull request only modifies tests. * Closes: #37253 Authored-by: Kevin Gurney <kgurney@mathworks.com> Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…lds`, `BitWidth`, and `ID` properties can not be modified to `hFixedWidth` test class (apache#37316) ### Rationale for this change As @ sgilmore10 pointed out in apache#37250 (comment), it makes sense to move the tests which verify that the `NumFields`, `BitWidth`, and `ID` properties cannot be set into the `hFixedWidthType` superclass, rather than having these tests implemented in `tTime32Type` and `tTime64Type`, since they are common to all fixed width types. ### What changes are included in this PR? 1. Moved tests which verify that the `BitWidth`, `NumFields`, and `ID` properties cannot be set out of the `tTime32Type` and `tTime64Type` classes and into the superclass `hFixedWidthType`. 2. Fixed typo in `tTime32Type` and `tTime64Type`. Changed variable name `schema` to `type`. ### Are these changes tested? Yes. 1. Moved tests which verify that the `BitWidth`, `NumFields`, and `ID` properties cannot be set out of the `tTime32Type` and `tTime64Type` classes and into the superclass `hFixedWidthType`. ### Are there any user-facing changes? No. This pull request only modifies tests. * Closes: apache#37253 Authored-by: Kevin Gurney <kgurney@mathworks.com> Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
As @sgilmore10 pointed out in #37250 (comment), it would make sense to add tests which verify that the
NumFields
,BitWidth
, andID
fields can not be modified on anyFixedWidthType
.Component(s)
MATLAB
The text was updated successfully, but these errors were encountered: