Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Add test for new nixlibs.R #38430

Closed
assignUser opened this issue Oct 24, 2023 · 3 comments · Fixed by #38534
Closed

[R] Add test for new nixlibs.R #38430

assignUser opened this issue Oct 24, 2023 · 3 comments · Fixed by #38534
Assignees
@paleolimbot
Labels
Component: R Type: enhancement
Milestone
14.0.2

Comments

@assignUser
Copy link
Member

Describe the enhancement requested

#38236 and previous PRs add new functionality to nixlibs.R which are mostly not covered in test-nixlibs.R.

Component(s)

R
@assignUser assignUser mentioned this issue Oct 24, 2023
Merged
@paleolimbot
Copy link
Member

We need to fix #37792 (comment) while we're here!

@paleolimbot
Copy link
Member

Also, a fun error from the other R build log:

Error : invalid version specification ‘integer(0).integer(0).integer(0).integer(0)’
⠏ |          0 | nixlibs                                                        *** Failed to find latest nightly for 8.0.0.9000

@assignUser
Copy link
Member Author

Ah yeah for the tests we set the version to that... some gating required I guess ^^

@github-actions github-actions bot mentioned this issue Oct 31, 2023
Merged
paleolimbot added a commit that referenced this issue Nov 10, 2023
@paleolimbot @jonkeane
GH-38430: [R] Add test + fix corner cases after nixlibs.R refactor (#…
c260a24 
…38534)

### Rationale for this change

A few rough edges exist after #38236 including:

- When zero or 1 nightly with the matching major version exist, detection of the latest nightly might fail
- At least one CI job is pulling nightlies instead of using the version from the current commit

### What changes are included in this PR?

- Clean up `find_latest_nightly()` + add test
- Ensure all CI jobs are not using `find_latest_nightly()`

### Are these changes tested?

Yes (test added)

### Are there any user-facing changes?

No
* Closes: #38430

Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
@paleolimbot paleolimbot added this to the 15.0.0 milestone Nov 10, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@paleolimbot @jonkeane @loicalleyne
apacheGH-38430: [R] Add test + fix corner cases after nixlibs.R refac…
c99762d 
…tor (apache#38534)

### Rationale for this change

A few rough edges exist after apache#38236 including:

- When zero or 1 nightly with the matching major version exist, detection of the latest nightly might fail
- At least one CI job is pulling nightlies instead of using the version from the current commit

### What changes are included in this PR?

- Clean up `find_latest_nightly()` + add test
- Ensure all CI jobs are not using `find_latest_nightly()`

### Are these changes tested?

Yes (test added)

### Are there any user-facing changes?

No
* Closes: apache#38430

Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
@assignUser assignUser modified the milestones: 15.0.0, 14.0.2 Nov 27, 2023
raulcd pushed a commit that referenced this issue Nov 28, 2023
@paleolimbot @jonkeane @raulcd
GH-38430: [R] Add test + fix corner cases after nixlibs.R refactor (#…
b0b4eb2 
…38534)

### Rationale for this change

A few rough edges exist after #38236 including:

- When zero or 1 nightly with the matching major version exist, detection of the latest nightly might fail
- At least one CI job is pulling nightlies instead of using the version from the current commit

### What changes are included in this PR?

- Clean up `find_latest_nightly()` + add test
- Ensure all CI jobs are not using `find_latest_nightly()`

### Are these changes tested?

Yes (test added)

### Are there any user-facing changes?

No
* Closes: #38430

Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
assignUser pushed a commit to assignUser/arrow that referenced this issue Dec 1, 2023
@paleolimbot @jonkeane @assignUser
apacheGH-38430: [R] Add test + fix corner cases after nixlibs.R refac…
d11bf92 
…tor (apache#38534)

### Rationale for this change

A few rough edges exist after apache#38236 including:

- When zero or 1 nightly with the matching major version exist, detection of the latest nightly might fail
- At least one CI job is pulling nightlies instead of using the version from the current commit

### What changes are included in this PR?

- Clean up `find_latest_nightly()` + add test
- Ensure all CI jobs are not using `find_latest_nightly()`

### Are these changes tested?

Yes (test added)

### Are there any user-facing changes?

No
* Closes: apache#38430

Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@paleolimbot @jonkeane @dgreiss
apacheGH-38430: [R] Add test + fix corner cases after nixlibs.R refac…
2845207 
…tor (apache#38534)

### Rationale for this change

A few rough edges exist after apache#38236 including:

- When zero or 1 nightly with the matching major version exist, detection of the latest nightly might fail
- At least one CI job is pulling nightlies instead of using the version from the current commit

### What changes are included in this PR?

- Clean up `find_latest_nightly()` + add test
- Ensure all CI jobs are not using `find_latest_nightly()`

### Are these changes tested?

Yes (test added)

### Are there any user-facing changes?

No
* Closes: apache#38430

Lead-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paleolimbot paleolimbot

Labels
Component: R Type: enhancement
Projects
None yet
Milestone
14.0.2
Development

Successfully merging a pull request may close this issue.

GH-38430: [R] Add test + fix corner cases after nixlibs.R refactor paleolimbot/arrow
2 participants
@paleolimbot @assignUser