Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FS][Azure] Implement DeleteDir() #38700

Closed
kou opened this issue Nov 14, 2023 · 0 comments · Fixed by #38793
Closed

[C++][FS][Azure] Implement DeleteDir() #38700

kou opened this issue Nov 14, 2023 · 0 comments · Fixed by #38793
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
15.0.0

Comments

@kou
Copy link
Member

kou commented Nov 14, 2023

Describe the enhancement requested

It's not implemented yet.

This is a child of GH-18014.

Component(s)

C++
@kou kou mentioned this issue Nov 14, 2023
Closed
kou added a commit to kou/arrow that referenced this issue Nov 20, 2023
@kou
apacheGH-38700: [C++][FS][Azure] Implement DeleteDir()
7e25d13
@github-actions github-actions bot mentioned this issue Nov 20, 2023
Merged
kou added a commit to kou/arrow that referenced this issue Nov 21, 2023
@kou
apacheGH-38700: [C++][FS][Azure] Implement DeleteDir()
7212e6a
@kou kou added this to the 15.0.0 milestone Nov 24, 2023
kou added a commit that referenced this issue Nov 24, 2023
@kou
GH-38700: [C++][FS][Azure] Implement DeleteDir() (#38793)
7da7895 
### Rationale for this change

`DeleteDir()` deletes the given directory recursively like other filesystem implementations.

### What changes are included in this PR?

* Container can be deleted with/without hierarchical namespace support.
* Directory can be deleted with hierarchical namespace support.
* Directory can't be deleted without hierarchical namespace support. But blobs under the given path can be deleted. So these blobs are deleted and the given virtual directory is also deleted.
    
### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #38700

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-38700: [C++][FS][Azure] Implement DeleteDir() (apache#38793)
d23baa1 
### Rationale for this change

`DeleteDir()` deletes the given directory recursively like other filesystem implementations.

### What changes are included in this PR?

* Container can be deleted with/without hierarchical namespace support.
* Directory can be deleted with hierarchical namespace support.
* Directory can't be deleted without hierarchical namespace support. But blobs under the given path can be deleted. So these blobs are deleted and the given virtual directory is also deleted.
    
### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#38700

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38700: [C++][FS][Azure] Implement DeleteDir() kou/arrow
1 participant
@kou