Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FS] Use default Azure credentials implicitly and support anonymous credentials explictly #39449

Closed
felipecrv opened this issue Jan 4, 2024 · 1 comment · Fixed by #39450
Closed

[C++][FS] Use default Azure credentials implicitly and support anonymous credentials explictly #39449

felipecrv opened this issue Jan 4, 2024 · 1 comment · Fixed by #39450
Assignees
@felipecrv
Labels
Component: C++ Type: enhancement
Milestone
15.0.0

Comments

@felipecrv
Copy link
Contributor

Describe the enhancement requested

As the next release is coming with a lot of the Azure FS implemented, I would like to propose a change to how AzureOptions works:

  • Use default credentials without any explicit AzureOptions::Configure- call
  • Support anonymous credentials (can only access public containers) instead of returning an error (but require an explicit call to ConfigureAnonymousCredential().

Component(s)

C++
felipecrv added a commit to felipecrv/arrow that referenced this issue Jan 4, 2024
@felipecrv
apacheGH-39449: [C++] Use default Azure credentials implicitly and su…
719f0fc 
…pport anonymous credentials explictly
felipecrv added a commit to felipecrv/arrow that referenced this issue Jan 4, 2024
@felipecrv
apacheGH-39449: [C++] Use default Azure credentials implicitly and su…
d2b77bd 
…pport anonymous credentials explictly
@github-actions github-actions bot mentioned this issue Jan 4, 2024
Merged
felipecrv added a commit to felipecrv/arrow that referenced this issue Jan 4, 2024
@felipecrv
apacheGH-39449: [C++] Use default Azure credentials implicitly and su…
a4053ad 
…pport anonymous credentials explictly
@Tom-Newton
Copy link
Contributor

Tom-Newton commented Jan 4, 2024 •
edited
Loading

I was going to make this ticket but I forgot. Thanks 👍

@kou kou mentioned this issue Jan 4, 2024
Closed
felipecrv added a commit to felipecrv/arrow that referenced this issue Jan 5, 2024
@felipecrv
apacheGH-39449: [C++] Use default Azure credentials implicitly and su…
fdf5931 
…pport anonymous credentials explictly
felipecrv added a commit that referenced this issue Jan 5, 2024
@felipecrv @kou
GH-39449: [C++] Use default Azure credentials implicitly and support …
33c64ed 
…anonymous credentials explicitly (#39450)

### Rationale for this change

 - Default credentials should be used by default.
 - There should be a way to connect to public containers without credentials (aka "anonymous credential").

### What changes are included in this PR?

 - Sync ordering of declarations and definitions in the `AzureOptions` classs
 - Use default credentials even when `ConfigureDefaultCredential()` isn't explicitly called
 - Create clients when `credential_kind_` is "anonymous" instead of returning an error
 
### Are these changes tested?

By new and existing tests.
* Closes: #39449

Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
@felipecrv felipecrv added this to the 15.0.0 milestone Jan 5, 2024
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@felipecrv @kou @clayburn
apacheGH-39449: [C++] Use default Azure credentials implicitly and su…
b9cbf80 
…pport anonymous credentials explicitly (apache#39450)

### Rationale for this change

 - Default credentials should be used by default.
 - There should be a way to connect to public containers without credentials (aka "anonymous credential").

### What changes are included in this PR?

 - Sync ordering of declarations and definitions in the `AzureOptions` classs
 - Use default credentials even when `ConfigureDefaultCredential()` isn't explicitly called
 - Create clients when `credential_kind_` is "anonymous" instead of returning an error
 
### Are these changes tested?

By new and existing tests.
* Closes: apache#39449

Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@felipecrv @kou @dgreiss
apacheGH-39449: [C++] Use default Azure credentials implicitly and su…
78479f2 
…pport anonymous credentials explicitly (apache#39450)

### Rationale for this change

 - Default credentials should be used by default.
 - There should be a way to connect to public containers without credentials (aka "anonymous credential").

### What changes are included in this PR?

 - Sync ordering of declarations and definitions in the `AzureOptions` classs
 - Use default credentials even when `ConfigureDefaultCredential()` isn't explicitly called
 - Create clients when `credential_kind_` is "anonymous" instead of returning an error
 
### Are these changes tested?

By new and existing tests.
* Closes: apache#39449

Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@felipecrv @kou @zanmato1984
apacheGH-39449: [C++] Use default Azure credentials implicitly and su…
18ec524 
…pport anonymous credentials explicitly (apache#39450)

### Rationale for this change

 - Default credentials should be used by default.
 - There should be a way to connect to public containers without credentials (aka "anonymous credential").

### What changes are included in this PR?

 - Sync ordering of declarations and definitions in the `AzureOptions` classs
 - Use default credentials even when `ConfigureDefaultCredential()` isn't explicitly called
 - Create clients when `credential_kind_` is "anonymous" instead of returning an error
 
### Are these changes tested?

By new and existing tests.
* Closes: apache#39449

Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
15.0.0
2 participants
@felipecrv @Tom-Newton