Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Packaging] Upgrade vcpkg version used for release builds #39621

Closed
Tom-Newton opened this issue Jan 15, 2024 · 2 comments · Fixed by #39622
Closed

[CI][Packaging] Upgrade vcpkg version used for release builds #39621

Tom-Newton opened this issue Jan 15, 2024 · 2 comments · Fixed by #39622
Assignees
@Tom-Newton
Labels
Component: Continuous Integration Component: Packaging Component: Release Type: enhancement
Milestone
16.0.0

Comments

@Tom-Newton
Copy link
Contributor

Describe the enhancement requested

Upgrade vcpkg to at least https://github.com/microsoft/vcpkg/releases/tag/2023.11.20

This is a pre-requisite for #39352
Relevant discussion:
#36835 (comment)
#39352 (comment)

Component(s)

Continuous Integration, Packaging, Release
@Tom-Newton
Copy link
Contributor Author

take

@Tom-Newton
Copy link
Contributor Author

Tom-Newton commented Jan 15, 2024 •
edited
Loading

I'm taking inspiration from #35430

Unfortunately, it looks like the whole of ci/vcpkg/ports.patch now fails to apply. I can update the patches - nothing looks particularly concerning but there are changes nearby to all the patches.

The main thing I'm unsure of is how this can be tested.

@github-actions github-actions bot mentioned this issue Jan 15, 2024
Merged
kou added a commit that referenced this issue Feb 6, 2024
@Tom-Newton @kou @raulcd
GH-39621: [CI][Packaging] Update vcpkg to 2023.11.20 release (#39622)
1552510 
### Rationale for this change
Old version of vcpkg is blocking #39352

### What changes are included in this PR?
- Upgrade vcpkg 
- Fix ports patches
- Upgrade visual studio used in windows wheel builds. VS2019 is now required for the vcpkg `abseil` build. 
- Move `VCPKG_FORCE_SYSTEM_BINARIES` to be set before vcpkg install to fix vcpkg install on linux ARM. 
- Fix for LLVM 17 which requires that an executable exports "llvm_orc_registerEHFrameSectionWrapper()" and "llvm_orc_unregisterEHFrameSectionWrapper()". This effects the java builds that depend on llvm from vcpkg for gandiva. 
- Update image used for python wheel builds on windows to 2024-02-05

### Are these changes tested?
Does not change any behaviour so should be covered by existing tests

### Are there any user-facing changes?
There shouldn't be
* Closes: #39621

Lead-authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou closed this as completed in #39622 Feb 6, 2024
@kou kou added this to the 16.0.0 milestone Feb 6, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@Tom-Newton @kou
@raulcd @dgreiss
apacheGH-39621: [CI][Packaging] Update vcpkg to 2023.11.20 release (a…
7fe27d1 
…pache#39622)

### Rationale for this change
Old version of vcpkg is blocking apache#39352

### What changes are included in this PR?
- Upgrade vcpkg 
- Fix ports patches
- Upgrade visual studio used in windows wheel builds. VS2019 is now required for the vcpkg `abseil` build. 
- Move `VCPKG_FORCE_SYSTEM_BINARIES` to be set before vcpkg install to fix vcpkg install on linux ARM. 
- Fix for LLVM 17 which requires that an executable exports "llvm_orc_registerEHFrameSectionWrapper()" and "llvm_orc_unregisterEHFrameSectionWrapper()". This effects the java builds that depend on llvm from vcpkg for gandiva. 
- Update image used for python wheel builds on windows to 2024-02-05

### Are these changes tested?
Does not change any behaviour so should be covered by existing tests

### Are there any user-facing changes?
There shouldn't be
* Closes: apache#39621

Lead-authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@Tom-Newton @kou
@raulcd @zanmato1984
apacheGH-39621: [CI][Packaging] Update vcpkg to 2023.11.20 release (a…
fc06112 
…pache#39622)

### Rationale for this change
Old version of vcpkg is blocking apache#39352

### What changes are included in this PR?
- Upgrade vcpkg 
- Fix ports patches
- Upgrade visual studio used in windows wheel builds. VS2019 is now required for the vcpkg `abseil` build. 
- Move `VCPKG_FORCE_SYSTEM_BINARIES` to be set before vcpkg install to fix vcpkg install on linux ARM. 
- Fix for LLVM 17 which requires that an executable exports "llvm_orc_registerEHFrameSectionWrapper()" and "llvm_orc_unregisterEHFrameSectionWrapper()". This effects the java builds that depend on llvm from vcpkg for gandiva. 
- Update image used for python wheel builds on windows to 2024-02-05

### Are these changes tested?
Does not change any behaviour so should be covered by existing tests

### Are there any user-facing changes?
There shouldn't be
* Closes: apache#39621

Lead-authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@Tom-Newton @kou
@raulcd @thisisnic
apacheGH-39621: [CI][Packaging] Update vcpkg to 2023.11.20 release (a…
8b66b89 
…pache#39622)

### Rationale for this change
Old version of vcpkg is blocking apache#39352

### What changes are included in this PR?
- Upgrade vcpkg 
- Fix ports patches
- Upgrade visual studio used in windows wheel builds. VS2019 is now required for the vcpkg `abseil` build. 
- Move `VCPKG_FORCE_SYSTEM_BINARIES` to be set before vcpkg install to fix vcpkg install on linux ARM. 
- Fix for LLVM 17 which requires that an executable exports "llvm_orc_registerEHFrameSectionWrapper()" and "llvm_orc_unregisterEHFrameSectionWrapper()". This effects the java builds that depend on llvm from vcpkg for gandiva. 
- Update image used for python wheel builds on windows to 2024-02-05

### Are these changes tested?
Does not change any behaviour so should be covered by existing tests

### Are there any user-facing changes?
There shouldn't be
* Closes: apache#39621

Lead-authored-by: Thomas Newton <thomas.w.newton@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tom-Newton Tom-Newton

Labels
Component: Continuous Integration Component: Packaging Component: Release Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-39621: [CI][Packaging] Update vcpkg to 2023.11.20 release Tom-Newton/arrow
2 participants
@kou @Tom-Newton