Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] Store timestamps as Int64 internally #40959

Closed
domoritz opened this issue Apr 2, 2024 · 0 comments
Closed

[JS] Store timestamps as Int64 internally #40959

domoritz opened this issue Apr 2, 2024 · 0 comments
Assignees
@domoritz
Labels
Component: JavaScript Type: enhancement
Milestone
16.1.0

Comments

@domoritz
Copy link
Member

domoritz commented Apr 2, 2024

Describe the enhancement requested

Right now, we store two int32s and then do a lot of bit math. This is because the code was written before BigInts were common in js.

Component(s)

JavaScript
@domoritz domoritz self-assigned this Apr 2, 2024
@github-actions github-actions bot mentioned this issue Apr 2, 2024
Merged
@domoritz domoritz added this to the 16.0.0 milestone Apr 16, 2024
domoritz added a commit that referenced this issue Apr 16, 2024
@domoritz
GH-40959: [JS] Store Timestamps in 64 bits (#40960)
18876b2 
Merge after #40892.

This pull request also changes Dates to return timestamps instead of
Date instances (similar to Timestamps and for the same reason.

* GitHub Issue: #40959
domoritz added a commit to domoritz/arrow that referenced this issue Apr 17, 2024
@domoritz
apacheGH-40959: [JS] Store Timestamps in 64 bits (apache#40960)
7471981 
Merge after apache#40892.

This pull request also changes Dates to return timestamps instead of
Date instances (similar to Timestamps and for the same reason.

* GitHub Issue: apache#40959
@domoritz domoritz modified the milestones: 16.0.0, 16.1.0 Apr 18, 2024
raulcd pushed a commit that referenced this issue Apr 29, 2024
@domoritz @raulcd
GH-40959: [JS] Store Timestamps in 64 bits (#40960)
1c430be 
Merge after #40892.

This pull request also changes Dates to return timestamps instead of
Date instances (similar to Timestamps and for the same reason.

* GitHub Issue: #40959
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
@domoritz @tolleybot
apacheGH-40959: [JS] Store Timestamps in 64 bits (apache#40960)
112bb3b 
Merge after apache#40892.

This pull request also changes Dates to return timestamps instead of
Date instances (similar to Timestamps and for the same reason.

* GitHub Issue: apache#40959
tolleybot pushed a commit to tmct/arrow that referenced this issue May 4, 2024
@domoritz @tolleybot
apacheGH-40959: [JS] Store Timestamps in 64 bits (apache#40960)
d3de823 
Merge after apache#40892.

This pull request also changes Dates to return timestamps instead of
Date instances (similar to Timestamps and for the same reason.

* GitHub Issue: apache#40959
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
@domoritz @rok
apacheGH-40959: [JS] Store Timestamps in 64 bits (apache#40960)
4a4812d 
Merge after apache#40892.

This pull request also changes Dates to return timestamps instead of
Date instances (similar to Timestamps and for the same reason.

* GitHub Issue: apache#40959
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
@domoritz @rok
apacheGH-40959: [JS] Store Timestamps in 64 bits (apache#40960)
6bdafb4 
Merge after apache#40892.

This pull request also changes Dates to return timestamps instead of
Date instances (similar to Timestamps and for the same reason.

* GitHub Issue: apache#40959
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@domoritz @vibhatha
apacheGH-40959: [JS] Store Timestamps in 64 bits (apache#40960)
f3f905c 
Merge after apache#40892.

This pull request also changes Dates to return timestamps instead of
Date instances (similar to Timestamps and for the same reason.

* GitHub Issue: apache#40959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domoritz domoritz

Labels
Component: JavaScript Type: enhancement
Projects
None yet
Milestone
16.1.0
Development

No branches or pull requests
1 participant
@domoritz