Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R][CI] CRAN-style openssl not being picked up #41426

Closed
assignUser opened this issue Apr 29, 2024 · 4 comments
Closed

[R][CI] CRAN-style openssl not being picked up #41426

assignUser opened this issue Apr 29, 2024 · 4 comments
Assignees
@assignUser
Labels
Component: Continuous Integration Component: R Type: bug
Milestone
17.0.0

Comments

@assignUser
Copy link
Member

assignUser commented Apr 29, 2024 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

We noticed in #41403 that the binary package build doesn't pick up the CRAN mac-recepies openssl. https://github.com/ursacomputing/crossbow/actions/runs/8872579257/job/24357521438#step:16:561

Likely because we switched to gh hosted runners that don't have it installed. See https://mac.r-project.org/bin/

Component(s)

Continuous Integration, R
@jonkeane
Copy link
Member

I believe this is also causing the builds we are hosting to be slightly busted. I just tried installing a nightly on arm64 and found that gzip wasn't enabled.

Which makes sense since we create these binaries after failing to find openssl, but with a minimal build: https://github.com/ursacomputing/crossbow/actions/runs/8891743595/job/24415201349#step:16:72

@jonkeane
Copy link
Member

@assignUser Have you had a chance to figure out what's going wrong here?

@assignUser
Copy link
Member Author

Not yet sorry but I think the fix should be easy(tm) I'll have a look overt the weekend.

@github-actions github-actions bot mentioned this issue May 12, 2024
Merged
assignUser added a commit that referenced this issue May 21, 2024
@assignUser
GH-41426: [R][CI] Install CRAN style openssl on gh runners. (#41629)
f0678ec 
### Rationale for this change

See issue.

### What changes are included in this PR?

Enforce usage of binary and install of cran openssl version on intel and arm macos.

### Are these changes tested?
Crossbow
* GitHub Issue: #41426

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 17.0.0 milestone May 21, 2024
@assignUser
Copy link
Member Author

Issue resolved by pull request 41629
#41629

assignUser added a commit that referenced this issue May 21, 2024
@assignUser
GH-41426: [R][CI] Install CRAN style openssl on gh runners. (#41629)
4d73284 
### Rationale for this change

See issue.

### What changes are included in this PR?

Enforce usage of binary and install of cran openssl version on intel and arm macos.

### Are these changes tested?
Crossbow
* GitHub Issue: #41426

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@assignUser @vibhatha
apacheGH-41426: [R][CI] Install CRAN style openssl on gh runners. (ap…
7776102 
…ache#41629)

### Rationale for this change

See issue.

### What changes are included in this PR?

Enforce usage of binary and install of cran openssl version on intel and arm macos.

### Are these changes tested?
Crossbow
* GitHub Issue: apache#41426

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@assignUser assignUser

Labels
Component: Continuous Integration Component: R Type: bug
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@jonkeane @assignUser