Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go][FlightRPC] Stateless prepared statements don't actually work #41427

Closed
lidavidm opened this issue Apr 29, 2024 · 3 comments
Closed

[Go][FlightRPC] Stateless prepared statements don't actually work #41427

lidavidm opened this issue Apr 29, 2024 · 3 comments

Comments

@lidavidm
Copy link
Member

https://github.com/erratic-pattern/arrow/blob/af0765eebfc67579b369e80b5c3d600b580cfcf8/go/arrow/flight/flightsql/client.go#L1110-L1141

We capture the new value, but we continue to use the old desc in the final call to getFlightInfo

Originally posted by @lidavidm in #40311 (comment)

@lidavidm lidavidm self-assigned this Apr 29, 2024
lidavidm added a commit to lidavidm/arrow that referenced this issue Apr 29, 2024
lidavidm added a commit that referenced this issue Apr 29, 2024
### Rationale for this change

Stateless prepared statements didn't actually work

### What changes are included in this PR?

Update the handle after binding parameters

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* GitHub Issue: #41427

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 17.0.0 milestone Apr 29, 2024
@lidavidm
Copy link
Member Author

Issue resolved by pull request 41428
#41428

@alamb
Copy link
Contributor

alamb commented Apr 30, 2024

Thank you @lidavidm

tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
### Rationale for this change

Stateless prepared statements didn't actually work

### What changes are included in this PR?

Update the handle after binding parameters

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* GitHub Issue: apache#41427

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@matthewmturner
Copy link

Cross posting here from a comment I made on the PR for this.

"FYI we are still seeing having issues with stateless prepared statements from go. It seems to be working from a rust client but something going on with the deserialization of the handle where the data in handle is ending up unknown fields of DoPutPreparedStatementResult instead of prepared_statement_handle.

It's possible that the issue is actually on our side but given that the rust client worked without issue I'm inclined to think its on the go client side. I am looking into it, but wanted to raise it here as well."

tolleybot pushed a commit to tmct/arrow that referenced this issue May 4, 2024
### Rationale for this change

Stateless prepared statements didn't actually work

### What changes are included in this PR?

Update the handle after binding parameters

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* GitHub Issue: apache#41427

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
### Rationale for this change

Stateless prepared statements didn't actually work

### What changes are included in this PR?

Update the handle after binding parameters

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* GitHub Issue: apache#41427

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
### Rationale for this change

Stateless prepared statements didn't actually work

### What changes are included in this PR?

Update the handle after binding parameters

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* GitHub Issue: apache#41427

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
### Rationale for this change

Stateless prepared statements didn't actually work

### What changes are included in this PR?

Update the handle after binding parameters

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* GitHub Issue: apache#41427

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants