Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Update Unit Tests to use org.junit.jupiter.api #41680

Closed
12 tasks done
vibhatha opened this issue May 16, 2024 · 16 comments
Closed
12 tasks done

[Java] Update Unit Tests to use org.junit.jupiter.api #41680

vibhatha opened this issue May 16, 2024 · 16 comments

Comments

@vibhatha
Copy link
Collaborator

vibhatha commented May 16, 2024

Describe the enhancement requested

At the moment, test cases are using an older API version of Junit, and this should be upgraded to use the latest API.
It would be best if we can do this module per module by creating an issue per module and list it here.

Component(s)

Java

@llama90
Copy link
Contributor

llama90 commented Jun 9, 2024

@vibhatha I have verified the c module using only JUnit 5. Please cross-check when you have free time. Thank you.

@vibhatha
Copy link
Collaborator Author

vibhatha commented Jun 9, 2024

@vibhatha I have verified the c module using only JUnit 5. Please cross-check when you have free time. Thank you.

@llama90 thank you for checking this one. I will verify. I will update tomorrow. Really appreciate your support on this upgrade.

@vibhatha
Copy link
Collaborator Author

vibhatha commented Jun 9, 2024

@llama90 You are correct, we don't need to work on c module. It is already in JUNIT5. Thanks for verifying this.

@llama90
Copy link
Contributor

llama90 commented Jun 10, 2024

@vibhatha I think I will start after merging the spotless changes for each module to avoid conflicts.

@vibhatha
Copy link
Collaborator Author

@llama90 that's good idea.

@llama90
Copy link
Contributor

llama90 commented Jun 12, 2024

@vibhatha Additionally, the performance module does not include tests, so there is no need to assign tasks for it.

Please cross-check when you have free time. Thank you.

@vibhatha
Copy link
Collaborator Author

@llama90 Done! Thanks for looking into this.

@llama90
Copy link
Contributor

llama90 commented Jun 16, 2024

@vibhatha
Copy link
Collaborator Author

@llama90 Thank you for updating it here. I will make sure to update the list. I am out today, will be a bit slow on reviews.

@llama90
Copy link
Contributor

llama90 commented Jun 17, 2024

No problem! Have a nice day.

lidavidm pushed a commit that referenced this issue Jun 17, 2024
### Rationale for this change

### What changes are included in this PR?

I followed the format for the other sub-issues of GH-41680 (flight, etc.) 

### Are these changes tested?
Yes. This is actually migration of tests from JUnit 4 to JUnit 5. They  pass. 

### Are there any user-facing changes?

* GitHub Issue: #41680
* GitHub Issue: #42165

Authored-by: Ed and Gravy <me@emangini.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm
Copy link
Member

@vibhatha after this is done, we also need to remove all JUnit 4 dependencies and preferably exclude them so we don't accidentally re-take a dependency on JUnit 4

@vibhatha
Copy link
Collaborator Author

@lidavidm I will work on that. Definitely.

@vibhatha
Copy link
Collaborator Author

@lidavidm issue created: #42193

@llama90
Copy link
Contributor

llama90 commented Jun 22, 2024

Finally, we've completed this issue. Thank you for your effort, @lidavidm and @vibhatha.

It was interesting and helped me learn a lot. If there are any other issues I can help solve, please let me know. I'm not yet familiar with the entire codebase in Java, but I'm getting the hang of it.

Thank you!

@lidavidm
Copy link
Member

@llama90 thank you for finishing this off!

@vibhatha we can close now right?

@vibhatha
Copy link
Collaborator Author

Yes @lidavidm we can.

Thanks a lot @llama90 for pushing this till the end. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants