Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] fmpp-maven-plugin generates files directly under target/generated-sources #41787

Closed
laurentgo opened this issue May 22, 2024 · 2 comments
Closed

[Java] fmpp-maven-plugin generates files directly under target/generated-sources #41787

laurentgo opened this issue May 22, 2024 · 2 comments
Assignees
@laurentgo
Labels
Component: Java Type: bug
Milestone
17.0.0

Comments

@laurentgo
Copy link
Collaborator

Describe the bug, including details regarding any error messages, version, and platform.

fmpp-plugin-maven is used in arrow-vector module to generate source files before the compilation phase. Those files are generated directly under target/generated-sources where they conflict with the target/generated-sources/annotations directory created by javac. Per convention each plugin generates files under its own directory to prevent risks of conflicts.

Although it doesn't cause a direct issue with the build, it may also confuse some IDEs (Eclipse and VSCode notably) which are detecting overlapping source directories

Component(s)

Java
laurentgo added a commit to laurentgo/arrow that referenced this issue May 22, 2024
@laurentgo
apacheGH-41787: Update fmpp-maven-plugin output directory
1e23820 
Per convention fmpp-maven-plugin should not directly generate files
under target/generated-sources but into a subdirectory.

Changing config to output files under `target/generated-sources/fmpp`
@github-actions github-actions bot mentioned this issue May 22, 2024
Merged
@lidavidm
Copy link
Member

This also tends to confuse IntelliJ which expects a subdirectory, and so it doesn't see the generated sources -> IDE complains about undefined symbols

lidavidm pushed a commit that referenced this issue May 23, 2024
@laurentgo
GH-41787: Update fmpp-maven-plugin output directory (#41788)
420c01a 
### Rationale for this change

Per convention fmpp-maven-plugin should not directly generate files under target/generated-sources but into a subdirectory.

### What changes are included in this PR?

Changing config to output files under `target/generated-sources/fmpp`

### Are these changes tested?

CI

### Are there any user-facing changes?

No
* GitHub Issue: #41787

Authored-by: Laurent Goujon <laurent@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 17.0.0 milestone May 23, 2024
@lidavidm
Copy link
Member

Issue resolved by pull request 41788
#41788

vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@laurentgo @vibhatha
apacheGH-41787: Update fmpp-maven-plugin output directory (apache#41788)
d5fee51 
### Rationale for this change

Per convention fmpp-maven-plugin should not directly generate files under target/generated-sources but into a subdirectory.

### What changes are included in this PR?

Changing config to output files under `target/generated-sources/fmpp`

### Are these changes tested?

CI

### Are there any user-facing changes?

No
* GitHub Issue: apache#41787

Authored-by: Laurent Goujon <laurent@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurentgo laurentgo

Labels
Component: Java Type: bug
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@lidavidm @laurentgo