-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MATLAB] Executing tfeather.m
test class causes MATLAB to crash on windows-2022
after MSVC update from 14.39.33519 to 14.40.33807
#42015
Comments
Based on the stack trace, I suspect the root cause of the crash may be in the C++ Arrow bindings. I'll try reproducing this crash without using the MATLAB Arrow Interface. |
I actually think this crash is related to a compiler upgrade. The CXX compiler used in the last known good MATLAB workflow run was |
I found an issue within the Given that the stack trace above indicates the crash occurred in |
Can we upgrade Workaround: Defining diff --git a/matlab/CMakeLists.txt b/matlab/CMakeLists.txt
index d8ed65ce92..be4cb19389 100644
--- a/matlab/CMakeLists.txt
+++ b/matlab/CMakeLists.txt
@@ -36,7 +36,8 @@ function(build_arrow)
set(ARROW_BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/arrow_ep-build")
set(ARROW_CMAKE_ARGS
"-DCMAKE_INSTALL_PREFIX=${ARROW_PREFIX}" "-DCMAKE_INSTALL_LIBDIR=lib"
- "-DARROW_BUILD_STATIC=OFF" "-DARROW_CSV=ON")
+ "-DARROW_BUILD_STATIC=OFF" "-DARROW_CSV=ON"
+ "-DARROW_CXXFLAGS=-D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR")
add_library(arrow_shared SHARED IMPORTED)
set(ARROW_LIBRARY_TARGET arrow_shared) |
Unfortunately, I don't think upgrading the |
OK. #10004 and #10020 will not solve this problem. I think that #10004 and #10020 will be solved by upgrading It seems that we need to use |
tfeather.m
test class causes MATLAB to crash on Windowstfeather.m
test class causes MATLAB to crash on windows-2022
after MSVC update from 14.39.33519 to 14.40.33807
… crash on `windows-2022` after MSVC update from 14.39.33519 to 14.40.33807 (#42123) ### Rationale for this change After the `windows-2022` GitHub runner image was updated last week, MATLAB began crashing when running the unit tests in `arrow/matlab/test/tfeather.m` on Windows. As part of the update, VS 2022 was updated from `17.9.34902.65` to `17.10.34928.147` and MSVC was updated from `14.39.33519` to `14.40.33807`. It looks like many other projects have run into this issue as well: 1. actions/runner-images#10004 2. actions/runner-images#10020 The suggested workaround for this crash is to supply the flag `_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR` when building. ### What changes are included in this PR? 1. Supply `_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR` flag when building Arrow C++. ### Are these changes tested? N/A. Existing tests used. ### Are there any user-facing changes? No. * GitHub Issue: #42015 Authored-by: Sarah Gilmore <sgilmore@mathworks.com> Signed-off-by: Sarah Gilmore <sgilmore@mathworks.com>
Issue resolved by pull request 42123 |
Describe the bug, including details regarding any error messages, version, and platform.
After syncing
mathworks/arrow:main
branch to be up to date withapache/arrow:main
, the MATLAB GitHub Action now crashes when executingtfeather.m
on Windows.Here's the stack trace:
Component(s)
MATLAB
The text was updated successfully, but these errors were encountered: