Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Array fails gracefully on non-cpu devices #42112

Closed
Tracked by #41665
danepitkin opened this issue Jun 11, 2024 · 1 comment
Closed
Tracked by #41665

[Python] Array fails gracefully on non-cpu devices #42112

danepitkin opened this issue Jun 11, 2024 · 1 comment
Assignees
@danepitkin
Labels
Component: Python Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. Type: enhancement
Milestone
17.0.0

Comments

@danepitkin
Copy link
Member

Describe the enhancement requested

Common Array APIs should not segfault or abort when called on non-cpu devices.

Component(s)

Python
@danepitkin danepitkin mentioned this issue Jun 11, 2024
Closed
4 tasks
@github-actions github-actions bot mentioned this issue Jun 11, 2024
Merged
jorisvandenbossche added a commit that referenced this issue Jun 26, 2024
@danepitkin @jorisvandenbossche
GH-42112: [Python] Array gracefully fails on non-cpu device (#42113)
a42ec1d 
### Rationale for this change

Common `Array` APIs should not segfault or abort on non-cpu devices.

### What changes are included in this PR?

* `device_type` and `is_cpu` methods added to the `Array` class
* Any function that segfaults, aborts, or gives incorrect results on non-cpu devices now raises an exception 

### Are these changes tested?

* Unit tests added

### Are there any user-facing changes?

* `device_type` and `is_cpu` methods added to the `Array` class
* GitHub Issue: #42112

Lead-authored-by: Dane Pitkin <dpitkin@apache.org>
Co-authored-by: Dane Pitkin <dpitkin.oss@gmail.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche added this to the 17.0.0 milestone Jun 26, 2024
@jorisvandenbossche
Copy link
Member

Issue resolved by pull request 42113
#42113

zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Jul 9, 2024
@danepitkin @jorisvandenbossche @zanmato1984
apacheGH-42112: [Python] Array gracefully fails on non-cpu device (ap…
3b4b175 
…ache#42113)

### Rationale for this change

Common `Array` APIs should not segfault or abort on non-cpu devices.

### What changes are included in this PR?

* `device_type` and `is_cpu` methods added to the `Array` class
* Any function that segfaults, aborts, or gives incorrect results on non-cpu devices now raises an exception 

### Are these changes tested?

* Unit tests added

### Are there any user-facing changes?

* `device_type` and `is_cpu` methods added to the `Array` class
* GitHub Issue: apache#42112

Lead-authored-by: Dane Pitkin <dpitkin@apache.org>
Co-authored-by: Dane Pitkin <dpitkin.oss@gmail.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@amoeba amoeba added the Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. label Jul 29, 2024
@jorisvandenbossche jorisvandenbossche mentioned this issue Aug 1, 2024
Open
@felipecrv felipecrv mentioned this issue Aug 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danepitkin danepitkin

Labels
Component: Python Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
3 participants
@amoeba @jorisvandenbossche @danepitkin