Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Support list-view arrays in list_parent_indices #42235

Closed
Tracked by #37249
felipecrv opened this issue Jun 20, 2024 · 1 comment
Closed
Tracked by #37249

[C++] Support list-view arrays in list_parent_indices #42235

felipecrv opened this issue Jun 20, 2024 · 1 comment
Assignees
@felipecrv
Labels
Component: C++ Type: enhancement
Milestone
17.0.0

Comments

@felipecrv
Copy link
Contributor

Describe the enhancement requested

The list_parent_indices should accept arrays of ListView and LargeListView type.

Component(s)

C++
@felipecrv felipecrv self-assigned this Jun 20, 2024
@github-actions github-actions bot mentioned this issue Jun 20, 2024
Merged
@felipecrv felipecrv mentioned this issue Jun 21, 2024
Open
10 tasks
pitrou added a commit that referenced this issue Jun 26, 2024
@felipecrv @pitrou
GH-42235: [C++] list_parent_indices: Add support for list-view types (#…
508bdaa 
…42236)

### Rationale for this change

Completing the support of list-views.

### What changes are included in this PR?

Implementation of the `list_parent_indices` function for `ListViewType` and `LargeListViewType`.

### Are these changes tested?

Yes, by new unit tests.

### Are there any user-facing changes?

More complete support of list-views.
* GitHub Issue: #42235

Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou
Copy link
Member

pitrou commented Jun 26, 2024

Issue resolved by pull request 42236
#42236

@pitrou pitrou added this to the 17.0.0 milestone Jun 26, 2024
@pitrou pitrou closed this as completed Jun 26, 2024
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Jul 9, 2024
@felipecrv @pitrou @zanmato1984
apacheGH-42235: [C++] list_parent_indices: Add support for list-view …
f071ad1 
…types (apache#42236)

### Rationale for this change

Completing the support of list-views.

### What changes are included in this PR?

Implementation of the `list_parent_indices` function for `ListViewType` and `LargeListViewType`.

### Are these changes tested?

Yes, by new unit tests.

### Are there any user-facing changes?

More complete support of list-views.
* GitHub Issue: apache#42235

Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@felipecrv @pitrou