Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Always prefer mimalloc over jemalloc #43254

Closed
pitrou opened this issue Jul 15, 2024 · 2 comments
Closed

[C++] Always prefer mimalloc over jemalloc #43254

pitrou opened this issue Jul 15, 2024 · 2 comments
Assignees
@pitrou
Labels
Component: C++ Type: enhancement
Milestone
18.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Jul 15, 2024

Describe the enhancement requested

As discussed on the mailing-list, we should switch the default memory pool to mimalloc for all platforms. This would have several desirable effects:

  • less variability between platforms
  • mimalloc generally has a nicer, more consistent API and is easier to
    work with (in particular, jemalloc's configuration scheme is slightly
    abtruse)
  • potentially better performance, or at least not significantly worse,
    than the statu quo

Component(s)

C++
@github-actions github-actions bot mentioned this issue Jul 15, 2024
Merged
pitrou added a commit that referenced this issue Jul 16, 2024
@pitrou @kou
GH-43254: [C++] Always prefer mimalloc to jemalloc (#40875)
36fe1da 
### Rationale for this change

As discussed [on the mailing-list](https://lists.apache.org/thread/dts9ggvkthczfpmd25wrz449mxod76o2), this PR switches the default memory pool to mimalloc for all platforms. This should have several desirable effects:

* less variability between platforms
* mimalloc generally has a nicer, more consistent API and is easier to work with (in particular, jemalloc's configuration scheme is slightly abtruse)
* potentially better performance, or at least not significantly worse, than the statu quo

### Are these changes tested?

Yes, by existing CI configurations.

### Are there any user-facing changes?

Behavior should not change. Performance characteristics of some user workloads might improve or regress, but this is something we cannot predict in advance.

* GitHub Issue: #43254

Lead-authored-by: Antoine Pitrou <antoine@python.org>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 18.0.0 milestone Jul 16, 2024
@pitrou
Copy link
Member Author

pitrou commented Jul 16, 2024

Issue resolved by pull request 40875
#40875

@pitrou pitrou closed this as completed Jul 16, 2024
@mapleFU mapleFU mentioned this issue Jul 17, 2024
Merged
@pitrou pitrou mentioned this issue Oct 9, 2024
Closed
@pitrou
Copy link
Member Author

pitrou commented Oct 9, 2024

For posterity: another reason to prefer mimalloc is jemalloc/jemalloc#467 (probably the cause for #44342)

@kou kou mentioned this issue Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
1 participant
@pitrou