Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] RecordBatch should fail gracefully on non-cpu devices #43727

Closed
Tracked by #41665
danepitkin opened this issue Aug 16, 2024 · 1 comment
Closed
Tracked by #41665

[Python] RecordBatch should fail gracefully on non-cpu devices #43727

danepitkin opened this issue Aug 16, 2024 · 1 comment

Comments

@danepitkin
Copy link
Member

Describe the enhancement requested

RecordBatch should throw Python exceptions instead of segfaults when trying to access non-cpu data from the cpu.

Component(s)

Python

@danepitkin danepitkin changed the title [Python] RecordBatch fails gracefully on non-cpu devices [Python] RecordBatch should fail gracefully on non-cpu devices Aug 16, 2024
danepitkin added a commit to danepitkin/arrow that referenced this issue Aug 16, 2024
danepitkin added a commit to danepitkin/arrow that referenced this issue Aug 22, 2024
jorisvandenbossche pushed a commit that referenced this issue Sep 4, 2024
…43729)

### Rationale for this change

Throw a python exception if a RecordBatch API isn't able to be used when the memory is backed by non-cpu devices.

### What changes are included in this PR?

* Assert the device is CPU for APIs that only support CPU

### Are these changes tested?

Pytests

### Are there any user-facing changes?

The user experiences Python exceptions instead of segfaults for unsupported APIs.
* GitHub Issue: #43727

Authored-by: Dane Pitkin <dpitkin@apache.org>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche added this to the 18.0.0 milestone Sep 4, 2024
@jorisvandenbossche
Copy link
Member

Issue resolved by pull request 43729
#43729

zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Sep 6, 2024
…ces (apache#43729)

### Rationale for this change

Throw a python exception if a RecordBatch API isn't able to be used when the memory is backed by non-cpu devices.

### What changes are included in this PR?

* Assert the device is CPU for APIs that only support CPU

### Are these changes tested?

Pytests

### Are there any user-facing changes?

The user experiences Python exceptions instead of segfaults for unsupported APIs.
* GitHub Issue: apache#43727

Authored-by: Dane Pitkin <dpitkin@apache.org>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
khwilson pushed a commit to khwilson/arrow that referenced this issue Sep 14, 2024
…ces (apache#43729)

### Rationale for this change

Throw a python exception if a RecordBatch API isn't able to be used when the memory is backed by non-cpu devices.

### What changes are included in this PR?

* Assert the device is CPU for APIs that only support CPU

### Are these changes tested?

Pytests

### Are there any user-facing changes?

The user experiences Python exceptions instead of segfaults for unsupported APIs.
* GitHub Issue: apache#43727

Authored-by: Dane Pitkin <dpitkin@apache.org>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants