Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python][CI] Python minimal examples fail due to dataset not being present #44369

Closed
raulcd opened this issue Oct 10, 2024 · 1 comment
Closed

[Python][CI] Python minimal examples fail due to dataset not being present #44369

raulcd opened this issue Oct 10, 2024 · 1 comment
Assignees
@raulcd
Labels
Component: Continuous Integration Component: Python Type: bug
Milestone
18.0.0

Comments

@raulcd
Copy link
Member

raulcd commented Oct 10, 2024 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

Since #43740 was merge the minimal python jobs have started failing:

This is due to dataset not being present but parametrize using it on python/pyarrow/tests/test_dataset.py::test_dataset_partitioning_format the error is:

 _ ERROR collecting miniconda-for-arrow/envs/pyarrow-3.10/lib/python3.10/site-packages/pyarrow/tests/test_dataset.py _
miniconda-for-arrow/envs/pyarrow-3.10/lib/python3.10/site-packages/pyarrow/tests/test_dataset.py:740: in <module>
    (ds.HivePartitioning, (r"foo=A/bar=ant%20bee", ""), ("", "")),
E   AttributeError: 'NoneType' object has no attribute 'HivePartitioning'

Component(s)

Continuous Integration, Python
@raulcd raulcd added this to the 18.0.0 milestone Oct 10, 2024
raulcd added a commit to raulcd/arrow that referenced this issue Oct 10, 2024
@raulcd
apacheGH-44369: [CI][Python] Remove ds requirement from test collecti…
d682c4f 
…on on test_dataset.py
@github-actions github-actions bot mentioned this issue Oct 10, 2024
Merged
kou pushed a commit that referenced this issue Oct 11, 2024
@raulcd
GH-44369: [CI][Python] Remove ds requirement from test collection on …
e0d1f51 
…test_dataset.py (#44370)

### Rationale for this change

If pyarrow has been built without dataset test collection errors due to pytest.mark.parametrize requiring dataset.

### What changes are included in this PR?

Move dataset requirement outside of test collection by removing it from the parametrization.

### Are these changes tested?

Via archery

### Are there any user-facing changes?

No
* GitHub Issue: #44369

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou
Copy link
Member

kou commented Oct 11, 2024

Issue resolved by pull request 44370
#44370

@kou kou closed this as completed Oct 11, 2024
raulcd added a commit that referenced this issue Oct 11, 2024
@raulcd
GH-44369: [CI][Python] Remove ds requirement from test collection on …
037485f 
…test_dataset.py (#44370)

### Rationale for this change

If pyarrow has been built without dataset test collection errors due to pytest.mark.parametrize requiring dataset.

### What changes are included in this PR?

Move dataset requirement outside of test collection by removing it from the parametrization.

### Are these changes tested?

Via archery

### Are there any user-facing changes?

No
* GitHub Issue: #44369

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulcd raulcd

Labels
Component: Continuous Integration Component: Python Type: bug
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@kou @raulcd