[CI][Dev] Apply ShellCheck lint to ci/scripts/c_glib_test.sh #44749
Assignees
Milestone
Comments
kou
added a commit
to kou/arrow
that referenced
this issue
Nov 17, 2024
…test.sh
```console
$ pre-commit run --show-diff-on-failure --color=always --all-files shellcheck
ShellCheck v0.10.0.......................................................Failed
- hook id: shellcheck
- exit code: 1
In ci/scripts/c_glib_test.sh line 25:
: ${ARROW_GLIB_VAPI:=true}
^----------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
In ci/scripts/c_glib_test.sh line 37:
pushd ${source_dir}
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pushd "${source_dir}"
In ci/scripts/c_glib_test.sh line 54:
pushd ${build_dir}
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pushd "${build_dir}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
https://www.shellcheck.net/wiki/SC2223 -- This default assignment may cause...
```
assignUser
pushed a commit
that referenced
this issue
Nov 18, 2024
#44750) ### Rationale for this change ```console $ pre-commit run --show-diff-on-failure --color=always --all-files shellcheck ShellCheck v0.10.0.......................................................Failed - hook id: shellcheck - exit code: 1 In ci/scripts/c_glib_test.sh line 25: : ${ARROW_GLIB_VAPI:=true} ^----------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. In ci/scripts/c_glib_test.sh line 37: pushd ${source_dir} ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pushd "${source_dir}" In ci/scripts/c_glib_test.sh line 54: pushd ${build_dir} ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pushd "${build_dir}" For more information: https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... https://www.shellcheck.net/wiki/SC2223 -- This default assignment may cause... ``` ### What changes are included in this PR? * Add missing quotes. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #44749 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
|
Issue resolved by pull request 44750 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
This is a sub issue of #44748.
Component(s)
Continuous Integration, Developer Tools
The text was updated successfully, but these errors were encountered: