-
Notifications
You must be signed in to change notification settings - Fork 4k
Closed
Description
Describe the enhancement requested
This is the sub issue #44748.
shellcheck ci/scripts/install_sccache.sh
In ci/scripts/install_sccache.sh line 22:
if [ "$#" -lt 1 -o "$#" -gt 3 ]; then
^-- SC2166 (warning): Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
In ci/scripts/install_sccache.sh line 42:
curl -L $SCCACHE_URL --output $SCCACHE_ARCHIVE
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
curl -L "$SCCACHE_URL" --output $SCCACHE_ARCHIVE
In ci/scripts/install_sccache.sh line 43:
curl -L $SCCACHE_URL.sha256 --output $SCCACHE_ARCHIVE.sha256
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
curl -L "$SCCACHE_URL".sha256 --output $SCCACHE_ARCHIVE.sha256
In ci/scripts/install_sccache.sh line 53:
sha256sum $SHA_ARGS $SCCACHE_ARCHIVE.sha256
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
sha256sum "$SHA_ARGS" $SCCACHE_ARCHIVE.sha256
In ci/scripts/install_sccache.sh line 55:
if [ ! -d $PREFIX ]; then
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ ! -d "$PREFIX" ]; then
In ci/scripts/install_sccache.sh line 56:
mkdir -p $PREFIX
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$PREFIX"
In ci/scripts/install_sccache.sh line 61:
tar -xzvf $SCCACHE_ARCHIVE --strip-component=1 --directory $PREFIX --exclude="sccache*/*E*E*"
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
tar -xzvf $SCCACHE_ARCHIVE --strip-component=1 --directory "$PREFIX" --exclude="sccache*/*E*E*"
In ci/scripts/install_sccache.sh line 62:
chmod a+x $PREFIX/sccache
^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
chmod a+x "$PREFIX"/sccache
In ci/scripts/install_sccache.sh line 65:
echo "$PREFIX" >> $GITHUB_PATH
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "$PREFIX" >> "$GITHUB_PATH"
In ci/scripts/install_sccache.sh line 67:
echo "SCCACHE_PATH=$PREFIX/sccache.exe" >> $GITHUB_ENV
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
echo "SCCACHE_PATH=$PREFIX/sccache.exe" >> "$GITHUB_ENV"
For more information:
https://www.shellcheck.net/wiki/SC2166 -- Prefer [ p ] || [ q ] as [ p -o q...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
Component(s)
Continuous Integration