-
Notifications
You must be signed in to change notification settings - Fork 4k
Closed
Description
Describe the bug, including details regarding any error messages, version, and platform.
The test-ubuntu-24.04-cpp-thread-sanitizer has been failing for several weeks with an error building s2n-tls-src. The following is only a part of the error as it's quite long:
In file included from /build/cpp/_deps/s2n-tls-src/crypto/s2n_certificate.c:30:
In file included from /build/cpp/_deps/s2n-tls-src/tls/s2n_connection.h:27:
In file included from /build/cpp/_deps/s2n-tls-src/tls/s2n_config.h:24:
In file included from /build/cpp/_deps/s2n-tls-src/tls/s2n_crl.h:21:
/build/cpp/_deps/s2n-tls-src/api/unstable/crl.h:54:11: error: parameter 's2n_crl_lookup_callback' not found in the function declaration [-Werror,-Wdocumentation]
54 | * @param s2n_crl_lookup_callback The function to be called for each received certificate.
| ^~~~~~~~~~~~~~~~~~~~~~~
/build/cpp/_deps/s2n-tls-src/api/unstable/crl.h:54:11: note: did you mean 'callback'?
54 | * @param s2n_crl_lookup_callback The function to be called for each received certificate.
| ^~~~~~~~~~~~~~~~~~~~~~~
| callback
/build/cpp/_deps/s2n-tls-src/crypto/s2n_certificate.c:143:62: error: implicit conversion loses integer precision: 'unsigned long' to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
143 | POSIX_GUARD(s2n_stuffer_growable_alloc(&key_out_stuffer, strlen(private_key_pem)));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~
/build/cpp/_deps/s2n-tls-src/utils/s2n_safety_macros.h:383:77: note: expanded from macro 'POSIX_GUARD'
383 | #define POSIX_GUARD(result) __S2N_ENSURE((result) > S2N_FAILURE, __S2N_ENSURE_CHECKED_RETURN(S2N_FAILURE))
| ^~~~~~
/build/cpp/_deps/s2n-tls-src/utils/s2n_ensure.h:35:15: note: expanded from macro '__S2N_ENSURE'
35 | if (!(cond)) { \
| ^~~~
/build/cpp/_deps/s2n-tls-src/crypto/s2n_certificate.c:221:31: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int' [-Werror,-Wshorten-64-to-32]
221 | const int num_san_names = sk_GENERAL_NAME_num(san_names);
| ~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/build/cpp/_deps/s2n-tls-src/crypto/s2n_certificate.c:238:37: error: implicit conversion loses integer precision: 'const size_t' (aka 'const unsigned long') to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
238 | if (s2n_alloc(san_blob, san_str_len)) {
| ~~~~~~~~~ ^~~~~~~~~~~
/build/cpp/_deps/s2n-tls-src/crypto/s2n_certificate.c:243:30: error: implicit conversion loses integer precision: 'const size_t' (aka 'const unsigned long') to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
243 | san_blob->size = san_str_len;
| ~ ^~~~~~~~~~~
/build/cpp/_deps/s2n-tls-src/crypto/s2n_certificate.c:796:60: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int' [-Werror,-Wshorten-64-to-32]
796 | X509_EXTENSION *x509_ext = X509_get_ext(x509_cert, loc);
| ~~~~~~~~~~~~ ^~~
15 errors generated.
Component(s)
Continuous Integration, C++