Skip to content

ARROW-12774 : [C++][Compute] replace_substring_regex() creates invalid arrays => crash #10320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nirandaperera wants to merge 1 commit into from
Closed

ARROW-12774 : [C++][Compute] replace_substring_regex() creates invalid arrays => crash #10320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/arrow/compute/kernels/scalar_string.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1332,7 +1332,7 @@ struct ReplaceSubString {

if (batch[0].kind() == Datum::ARRAY) {
// We already know how many strings we have, so we can use Reserve/UnsafeAppend
RETURN_NOT_OK(offset_builder.Reserve(batch[0].array()->length));
RETURN_NOT_OK(offset_builder.Reserve(batch[0].array()->length + 1));
offset_builder.UnsafeAppend(0); // offsets start at 0

const ArrayData& input = *batch[0].array();
Expand Down
8 changes: 8 additions & 0 deletions cpp/src/arrow/compute/kernels/scalar_string_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,14 @@ TYPED_TEST(TestStringKernels, ReplaceSubstringRegex) {
ReplaceSubstringOptions options_regex2{"(a.a)", "aba\\1"};
this->CheckUnary("replace_substring_regex", R"(["aaaaaa"])", this->type(),
R"(["abaaaaabaaaa"])", &options_regex2);

// ARROW-12774
ReplaceSubstringOptions options_regex3{"X", "Y"};
this->CheckUnary("replace_substring_regex",
R"(["A","A","A","A","A","A","A","A","A","A","A","A","A","A","A","A"])",
this->type(),
R"(["A","A","A","A","A","A","A","A","A","A","A","A","A","A","A","A"])",
&options_regex3);
}

TYPED_TEST(TestStringKernels, ReplaceSubstringRegexLimited) {
Expand Down