ARROW-13562: [R] Styler followups #10879
Conversation
r/Makefile
Outdated
| R -s -e 'setwd(".."); if (requireNamespace("styler")) styler::style_file(setdiff(system("git diff --name-only | grep r/.*R$$", intern = TRUE), c("r/tests/testthat/latin1.R", "r/data-raw/codegen.R")))' | ||
|
|
||
| style-all: | ||
| R -s -e 'styler::style_file(setdiff(dir(pattern = "R$$", recursive = TRUE), c("tests/testthat/latin1.R", "data-raw/codegen.R")))' |
There was a problem hiding this comment.
We don't have to do this here, but given all where we are putting them, I wonder if we want to make (or investigate if this exists in styler already...) a file in r/arrow that specifies which files are no-style so we only have one place we need it
There was a problem hiding this comment.
Turns out styler doesn't have this, though they are considering ways to do it. r-lib/styler#319
We could add our own and "just" source that file that lists the files we want to skip so that we only have to list them once.
Hi @nealrichardson, can you maybe tell us a bit more about problems with that so we could improve that? |
@lorenzwalthert the first thing I found was that, while style-on-save would clearly do something (like remove extra whitespace), I was still getting lint warnings about files not having a trailing newline. I didn't get this if I just ran |
|
Thanks @nealrichardson. I referenced your comment in an open issue (REditorSupport/languageserver#462), I hope this gets resolved. Regarding that formatting wasn't fired at all, I am unsure what the problem was. Just noted several issues in the above repo where the problem was the fact that styler is quite slow on unseen code (r-lib/styler#558). |
Adds styling tasks to the Makefile (for 🦖 like me; I found that the styling-on-save from vscode was not reliable). Also makes codegen.R generate styled R code. Closes apache#10879 from nealrichardson/styler2 Lead-authored-by: Jonathan Keane <jkeane@gmail.com> Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Adds styling tasks to the Makefile (for 🦖 like me; I found that the styling-on-save from vscode was not reliable). Also makes codegen.R generate styled R code.