Skip to content

ARROW-253: restrict ints to 8, 16, 32, or 64 bits in V1 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
julienledem wants to merge 1 commit into from
Closed

ARROW-253: restrict ints to 8, 16, 32, or 64 bits in V1 #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions cpp/src/arrow/ipc/metadata-internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ const std::shared_ptr<DataType> DOUBLE = std::make_shared<DoubleType>();

static Status IntFromFlatbuffer(
const flatbuf::Int* int_data, std::shared_ptr<DataType>* out) {
if (int_data->bitWidth() % 8 != 0) {
return Status::NotImplemented("Integers not in cstdint are not implemented");
}
if (int_data->bitWidth() > 64) {
return Status::NotImplemented("Integers with more than 64 bits not implemented");
}
if (int_data->bitWidth() < 8) {
return Status::NotImplemented("Integers with less than 8 bits not implemented");
}

switch (int_data->bitWidth()) {
case 8:
Expand All @@ -76,8 +76,7 @@ static Status IntFromFlatbuffer(
*out = int_data->is_signed() ? INT64 : UINT64;
break;
default:
*out = nullptr;
break;
return Status::NotImplemented("Integers not in cstdint are not implemented");
}
return Status::OK();
}
Expand Down
2 changes: 1 addition & 1 deletion format/Message.fbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ table Bit {
}

table Int {
bitWidth: int; // 1 to 64
bitWidth: int; // restricted to 8, 16, 32, and 64 in v1
is_signed: bool;
}

Expand Down