ARROW-14897: [CI][C++] Upgrade Clang Tools to 12 from 8

[kou]

No description provided.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-14897

[github-actions]

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

[kou]

@github-actions crossbow submit -g nightly

[github-actions]

Revision: e881881

Submitted crossbow builds: ursacomputing/crossbow @ actions-1210

Task	Status
almalinux-8-amd64
almalinux-8-arm64
amazon-linux-2-amd64
centos-7-amd64
centos-8-amd64
centos-8-arm64
conda-clean
conda-linux-gcc-py36-cpu-r40
conda-linux-gcc-py36-cuda
conda-osx-arm64-clang-py38
conda-osx-arm64-clang-py39
conda-osx-clang-py36-r40
conda-osx-clang-py37-r41
conda-osx-clang-py38
conda-osx-clang-py39
conda-win-vs2017-py36-r40
debian-bookworm-amd64
debian-bookworm-arm64
debian-bullseye-amd64
debian-bullseye-arm64
debian-buster-amd64
debian-buster-arm64
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
homebrew-cpp
homebrew-r-autobrew
java-jars
nuget
python-sdist
test-build-cpp-fuzz
test-build-vcpkg-win
test-conda-cpp
test-conda-cpp-valgrind
test-conda-python-3.10
test-conda-python-3.6
test-conda-python-3.6-pandas-0.23
test-conda-python-3.7
test-conda-python-3.7-hdfs-2.9.2
test-conda-python-3.7-hdfs-3.2.1
test-conda-python-3.7-kartothek-latest
test-conda-python-3.7-kartothek-master
test-conda-python-3.7-pandas-0.24
test-conda-python-3.7-pandas-latest
test-conda-python-3.7-spark-v3.1.2
test-conda-python-3.8
test-conda-python-3.8-hypothesis
test-conda-python-3.8-pandas-latest
test-conda-python-3.8-pandas-nightly
test-conda-python-3.8-spark-v3.2.0
test-conda-python-3.9
test-conda-python-3.9-dask-latest
test-conda-python-3.9-dask-master
test-conda-python-3.9-pandas-master
test-conda-python-3.9-spark-master
test-debian-10-cpp
test-debian-11-cpp
test-debian-11-go-1.15
test-debian-11-python-3
test-debian-c-glib
test-debian-ruby
test-fedora-33-cpp
test-fedora-33-python-3
test-fedora-r-clang-sanitizer
test-r-arrow-backwards-compatibility
test-r-depsource-auto
test-r-depsource-system
test-r-devdocs
test-r-gcc-11
test-r-install-local
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-valgrind
test-r-minimal-build
test-r-offline-maximal
test-r-offline-minimal
test-r-rhub-debian-gcc-devel-lto-latest
test-r-rhub-ubuntu-gcc-release-latest
test-r-rocker-r-base-latest
test-r-rstudio-r-base-4.1-centos7-devtoolset-8
test-r-rstudio-r-base-4.1-centos8
test-r-rstudio-r-base-4.1-focal
test-r-rstudio-r-base-4.1-opensuse15
test-r-rstudio-r-base-4.1-opensuse42
test-r-ubuntu-21.04
test-r-versions
test-skyhook-integration
test-ubuntu-18.04-cpp
test-ubuntu-18.04-cpp-release
test-ubuntu-18.04-cpp-static
test-ubuntu-18.04-python-3
test-ubuntu-18.04-r-sanitizer
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-14
test-ubuntu-20.04-cpp-17
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-20.10-docs
test-ubuntu-c-glib
test-ubuntu-default-docs
test-ubuntu-ruby
ubuntu-bionic-amd64
ubuntu-bionic-arm64
ubuntu-focal-amd64
ubuntu-focal-arm64
ubuntu-hirsute-amd64
ubuntu-hirsute-arm64
ubuntu-impish-amd64
ubuntu-impish-arm64
wheel-macos-big-sur-cp310-arm64
wheel-macos-big-sur-cp310-universal2
wheel-macos-big-sur-cp38-arm64
wheel-macos-big-sur-cp39-arm64
wheel-macos-big-sur-cp39-universal2
wheel-macos-high-sierra-cp310-amd64
wheel-macos-high-sierra-cp36-amd64
wheel-macos-high-sierra-cp37-amd64
wheel-macos-high-sierra-cp38-amd64
wheel-macos-high-sierra-cp39-amd64
wheel-macos-mavericks-cp310-amd64
wheel-macos-mavericks-cp36-amd64
wheel-macos-mavericks-cp37-amd64
wheel-macos-mavericks-cp38-amd64
wheel-macos-mavericks-cp39-amd64
wheel-manylinux2010-cp310-amd64
wheel-manylinux2010-cp36-amd64
wheel-manylinux2010-cp37-amd64
wheel-manylinux2010-cp38-amd64
wheel-manylinux2010-cp39-amd64
wheel-manylinux2014-cp310-amd64
wheel-manylinux2014-cp310-arm64
wheel-manylinux2014-cp36-amd64
wheel-manylinux2014-cp36-arm64
wheel-manylinux2014-cp37-amd64
wheel-manylinux2014-cp37-arm64
wheel-manylinux2014-cp38-amd64
wheel-manylinux2014-cp38-arm64
wheel-manylinux2014-cp39-amd64
wheel-manylinux2014-cp39-arm64
wheel-windows-cp310-amd64
wheel-windows-cp36-amd64
wheel-windows-cp37-amd64
wheel-windows-cp38-amd64
wheel-windows-cp39-amd64

[kou]

@pitrou @lidavidm @cyb70289 @bkietz @westonpace You may be interested in this.

[cyb70289]

+1

[mbrobbel]

There are some mentions in dev docs about the clang version:

• https://github.com/apache/arrow/blob/master/docs/source/developers/cpp/building.rst#llvm-and-clang-tools
• https://github.com/apache/arrow/blob/master/docs/source/developers/cpp/development.rst#code-style-linting-and-ci

• arrow/r/vignettes/developers/workflow.Rmd

  Line 90 in e417fbf

  The lint script requires Python 3 and `clang-format-8`. If the command

[lidavidm]

I think it'd be worth giving a heads-up on dev@, even though the diffs here are small/it seems we shouldn't have many conflicts.

[westonpace]

This would be rather helpful for me. I had to disable clang on clion because it kept reordering the headers and I think IncludeBlocks: Preserve is probably what I was missing so thanks for that 👍

It looks like the TravisCI failures are related. Googling suggests that maybe the TravisCI build host has out-of-date SSL root certificates and you might need to update libgnutls-openssl27 libgnutls30 in addition to ca-certificates but that is kind of a shot in the dark based on this

[kou]

@mbrobbel Good catch! I've updated documentations and they don't include the pinned version now.

@lidavidm It makes sense. I've sent an e-mail: https://lists.apache.org/thread/bd3rkllwgsrnqmmsn9zn5wo3cmjdn2b4

@westonpace Thanks for the hint. I've fixed it. You may be interested in R related changes after the first push:

• https://github.com/apache/arrow/pull/11786/files#diff-ed7e64d665cf68cc6341c9ec65825f1bb234cce6d6bfa73bbd2118ae6f1f8b06
• https://github.com/apache/arrow/pull/11786/files#diff-8119ec5b22c145ee54690a8e2da3f8dd45cb7fbee47f7c0193fda9034ec05325
• https://github.com/apache/arrow/pull/11786/files#diff-775b158a8cff027690c8e8ad70ee2f3e1c91fe82273d32868db2347e0663c596

[jonkeane]

This is fantastic, thank you!

There are a few places in dev/tasks/tasks.yml that had bespoke versions of CLANG_TOOLS to get them working that I don't think are needed anymore. I'm happy to push a commit to this branch (I would suggest changes, but GH doesn't let me do that on a file that's not near the diffs)

arrow/dev/tasks/tasks.yml

Line 1205 in 736a69e

CLANG_TOOLS: 9 # can remove this when >=9 is the default

arrow/dev/tasks/tasks.yml

Line 1193 in 736a69e

CLANG_TOOLS: 9 # can remove this when >=9 is the default

[kou]

@github-actions crossbow submit test-r-ubuntu-21.04 test-r-gcc-11

[kou]

@jonkeane Good catch! I've removed them.

[github-actions]

Revision: 8ab6937

Submitted crossbow builds: ursacomputing/crossbow @ actions-1227

Task	Status
test-r-gcc-11
test-r-ubuntu-21.04

[kou]

CI failures are unrelated. This is caused by https://packagemanager.rstudio.com/ . It returns 500.

I'll merge this.

[ursabot]

Benchmark runs are scheduled for baseline = 9ec01da and contender = f36451f. f36451f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.45% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.13% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True